Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 445023003: Move service library test into observatory package. (Closed)

Created:
6 years, 4 months ago by koda
Modified:
6 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org, ricow1
Visibility:
Public.

Description

Move service library test into observatory package. This depends on https://codereview.chromium.org/434883002/ R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=38985

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -60 lines) Patch
M runtime/bin/vmservice/client/HACKING.txt View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/pubspec.yaml View 1 chunk +2 lines, -1 line 0 comments Download
A + runtime/bin/vmservice/client/test/allocations_script.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/test/allocations_test.dart View 1 2 chunks +5 lines, -6 lines 0 comments Download
A runtime/bin/vmservice/client/test/test_helper.dart View 1 chunk +70 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D tests/standalone/vmservice/allocations_script.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tests/standalone/vmservice/allocations_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
koda
6 years, 4 months ago (2014-08-06 16:20:08 UTC) #1
Cutch
lgtm, but, consider adding a TESTING.txt to Observatory with an example command line to run ...
6 years, 4 months ago (2014-08-06 16:44:31 UTC) #2
koda
On 2014/08/06 16:44:31, Cutch wrote: > lgtm, but, consider adding a TESTING.txt to Observatory with ...
6 years, 4 months ago (2014-08-07 13:23:09 UTC) #3
koda
6 years, 4 months ago (2014-08-07 13:25:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r38985 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698