cc/resources/video_resource_updater.cc - Issue 445013002: media: Optimize HW Video to 2D Canvas copy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/video_resource_updater.cc

Issue 445013002: media: Optimize HW Video to 2D Canvas copy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't move SkCanvasVideoRenderer Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/resources/video_resource_updater.cc

diff --git a/cc/resources/video_resource_updater.cc b/cc/resources/video_resource_updater.cc

index a1286b917b4f2bde8af4248eb7654b2da202db4d..5b0b8e63545e4792d50a3edf3ce2a998456052dc 100644

--- a/cc/resources/video_resource_updater.cc

+++ b/cc/resources/video_resource_updater.cc

@@ -252,7 +252,8 @@ VideoFrameExternalResources VideoResourceUpdater::CreateForSoftwarePlanes(

video_renderer_->Paint(video_frame.get(),

lock.sk_canvas(),

video_frame->visible_rect(),

- 0xff);

+ 0xff,

+ 0);

danakj 2014/08/07 14:07:31 This should be NULL right? It's a pointer?

dshwang 2014/08/07 15:10:43 Done. I was confused with Blink coding style.

}

RecycleResourceData recycle_data = {