media: Optimize HW Video to 2D Canvas copy.

media/filters/skcanvas_video_renderer.h

Index: media/filters/skcanvas_video_renderer.h
diff --git a/media/filters/skcanvas_video_renderer.h b/media/filters/skcanvas_video_renderer.h
index 1e81d316f56555034fffdbfef72325d252a6944b..e2d402c72030c1825e3486eaf586d339a950f5c1 100644
--- a/media/filters/skcanvas_video_renderer.h
+++ b/media/filters/skcanvas_video_renderer.h
@@ -10,12 +10,12 @@
 #include "base/timer/timer.h"
 #include "media/base/media_export.h"
 #include "media/base/video_rotation.h"
+#include "media/filters/context_3d_provider.h"
 #include "third_party/skia/include/core/SkBitmap.h"
+#include "third_party/skia/include/core/SkCanvas.h"
 #include "third_party/skia/include/core/SkXfermode.h"
 #include "ui/gfx/rect.h"
 
-class SkCanvas;
-
 namespace media {
 
 class VideoFrame;
@@ -37,11 +37,21 @@ class MEDIA_EXPORT SkCanvasVideoRenderer {
              const gfx::RectF& dest_rect,
              uint8 alpha,
              SkXfermode::Mode mode,
-             VideoRotation video_rotation);
+             VideoRotation video_rotation,
+             const Context3DProvider& context_provider);
 
   // Copy |video_frame| on |canvas|.
   void Copy(const scoped_refptr<VideoFrame>&, SkCanvas* canvas);
 
+  static void CopyVideoFrameTextureToGLTexture(gpu::gles2::GLES2Interface* gl,

[scherkus (not reviewing), 2014/10/30 20:40:13]

can we get documentation?

for example, it'd be good to highlight that this requires NATIVE_TEXTURE

[dshwang, 2014/10/31 09:29:17]

Done.

+                                               media::VideoFrame* video_frame,

[scherkus (not reviewing), 2014/10/30 20:40:13]

nit: typically we pass these as const-ref (you can also drop the media:: prefix)

const scoped_refptr<VideoFrame>& video_frame

[danakj, 2014/10/30 21:04:20]

If you don't need a reference, passing a T* is more clear that you are not
passing something that you can take a reference on. I would recommend this over
const scoped_refptr<T>& when you don't need to take a ref on T.

[dshwang, 2014/10/31 09:29:17]

I preserve T* because it doesn't need to take a ref.
Paint() also has used T* before introducing VideoImageGenerator, which takes a
ref.

+                                               unsigned int texture,
+                                               unsigned int level,
+                                               unsigned int internal_format,
+                                               unsigned int type,
+                                               bool premultiply_alpha,
+                                               bool flip_y);
+
  private:
   void ResetLastFrame();
   void ResetAcceleratedLastFrame();