Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: media/filters/skcanvas_video_renderer.cc

Issue 445013002: media: Optimize HW Video to 2D Canvas copy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nits Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/filters/skcanvas_video_renderer.h" 5 #include "media/filters/skcanvas_video_renderer.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "gpu/GLES2/gl2extchromium.h"
9 #include "gpu/command_buffer/client/gles2_interface.h"
10 #include "gpu/command_buffer/common/mailbox_holder.h"
8 #include "media/base/video_frame.h" 11 #include "media/base/video_frame.h"
9 #include "media/base/yuv_convert.h" 12 #include "media/base/yuv_convert.h"
13 #include "skia/ext/refptr.h"
10 #include "third_party/libyuv/include/libyuv.h" 14 #include "third_party/libyuv/include/libyuv.h"
11 #include "third_party/skia/include/core/SkCanvas.h"
12 #include "third_party/skia/include/core/SkImageGenerator.h" 15 #include "third_party/skia/include/core/SkImageGenerator.h"
13 #include "third_party/skia/include/gpu/GrContext.h" 16 #include "third_party/skia/include/gpu/GrContext.h"
17 #include "third_party/skia/include/gpu/SkGrPixelRef.h"
14 #include "ui/gfx/skbitmap_operations.h" 18 #include "ui/gfx/skbitmap_operations.h"
15 19
16 // Skia internal format depends on a platform. On Android it is ABGR, on others 20 // Skia internal format depends on a platform. On Android it is ABGR, on others
17 // it is ARGB. 21 // it is ARGB.
18 #if SK_B32_SHIFT == 0 && SK_G32_SHIFT == 8 && SK_R32_SHIFT == 16 && \ 22 #if SK_B32_SHIFT == 0 && SK_G32_SHIFT == 8 && SK_R32_SHIFT == 16 && \
19 SK_A32_SHIFT == 24 23 SK_A32_SHIFT == 24
20 #define LIBYUV_I420_TO_ARGB libyuv::I420ToARGB 24 #define LIBYUV_I420_TO_ARGB libyuv::I420ToARGB
21 #define LIBYUV_I422_TO_ARGB libyuv::I422ToARGB 25 #define LIBYUV_I422_TO_ARGB libyuv::I422ToARGB
22 #elif SK_R32_SHIFT == 0 && SK_G32_SHIFT == 8 && SK_B32_SHIFT == 16 && \ 26 #elif SK_R32_SHIFT == 0 && SK_G32_SHIFT == 8 && SK_B32_SHIFT == 16 && \
23 SK_A32_SHIFT == 24 27 SK_A32_SHIFT == 24
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 row_bytes); 211 row_bytes);
208 video_frame->ReadPixelsFromNativeTexture(tmp); 212 video_frame->ReadPixelsFromNativeTexture(tmp);
209 break; 213 break;
210 } 214 }
211 default: 215 default:
212 NOTREACHED(); 216 NOTREACHED();
213 break; 217 break;
214 } 218 }
215 } 219 }
216 220
221 bool IsSkBitmapProperlySizedTexture(const SkBitmap* bitmap,
222 const gfx::Size& size) {
223 return bitmap->getTexture() && bitmap->width() == size.width() &&
224 bitmap->height() == size.height();
225 }
226
227 bool AllocateSkBitmapTexture(GrContext* gr,
228 SkBitmap* bitmap,
229 const gfx::Size& size) {
230 DCHECK(gr);
231 GrTextureDesc desc;
232 // Use kRGBA_8888_GrPixelConfig, not kSkia8888_GrPixelConfig, because
233 // glCopyTextureChromium doesn't support GL_BGRA_EXT as internal format.
234 desc.fConfig = kRGBA_8888_GrPixelConfig;
235 desc.fFlags = kRenderTarget_GrTextureFlagBit | kNoStencil_GrTextureFlagBit;
236 desc.fSampleCnt = 0;
237 desc.fOrigin = kTopLeft_GrSurfaceOrigin;
238 desc.fWidth = size.width();
239 desc.fHeight = size.height();
240 skia::RefPtr<GrTexture> texture = skia::AdoptRef(
241 gr->refScratchTexture(desc, GrContext::kExact_ScratchTexMatch));
242 if (!texture.get())
243 return false;
244
245 SkImageInfo info = SkImageInfo::MakeN32Premul(desc.fWidth, desc.fHeight);
246 SkGrPixelRef* pixel_ref = SkNEW_ARGS(SkGrPixelRef, (info, texture.get()));
247 if (!pixel_ref)
248 return false;
249 bitmap->setInfo(info);
250 bitmap->setPixelRef(pixel_ref)->unref();
251 return true;
252 }
253
254 bool CopyVideoFrameTextureToSkBitmapTexture(
255 VideoFrame* video_frame,
256 SkBitmap* bitmap,
257 const Context3DProvider& context_provider) {
258 // Check if we could reuse existing texture based bitmap.
259 // Otherwise, release existing texture based bitmap and allocate
260 // a new one based on video size.
261 if (!IsSkBitmapProperlySizedTexture(bitmap,
262 video_frame->visible_rect().size())) {
263 if (!AllocateSkBitmapTexture(context_provider.gr_context,
264 bitmap,
265 video_frame->visible_rect().size())) {
266 return false;
267 }
268 }
269
270 unsigned texture_id =
271 static_cast<unsigned>((bitmap->getTexture())->getTextureHandle());
272 // If CopyVideoFrameTextureToGLTexture() changes the state of the
273 // |texture_id|, it's needed to invalidate the state cached in skia,
274 // but currently the state isn't changed.
275 SkCanvasVideoRenderer::CopyVideoFrameTextureToGLTexture(context_provider.gl,
276 video_frame,
277 texture_id,
278 0,
279 GL_RGBA,
280 GL_UNSIGNED_BYTE,
281 true,
282 false);
283 return true;
284 }
285
286 class SyncPointClientImpl : public VideoFrame::SyncPointClient {
287 public:
288 explicit SyncPointClientImpl(gpu::gles2::GLES2Interface* gl) : gl_(gl) {}
289 ~SyncPointClientImpl() override {}
290 uint32 InsertSyncPoint() override {
291 return gl_->InsertSyncPointCHROMIUM();
292 }
293 void WaitSyncPoint(uint32 sync_point) override {
294 gl_->WaitSyncPointCHROMIUM(sync_point);
295 }
296
297 private:
298 gpu::gles2::GLES2Interface* gl_;
299
300 DISALLOW_IMPLICIT_CONSTRUCTORS(SyncPointClientImpl);
301 };
302
217 } // anonymous namespace 303 } // anonymous namespace
218 304
219 // Generates an RGB image from a VideoFrame. Convert YUV to RGB plain on GPU. 305 // Generates an RGB image from a VideoFrame. Convert YUV to RGB plain on GPU.
220 class VideoImageGenerator : public SkImageGenerator { 306 class VideoImageGenerator : public SkImageGenerator {
221 public: 307 public:
222 VideoImageGenerator(const scoped_refptr<VideoFrame>& frame) : frame_(frame) { 308 VideoImageGenerator(const scoped_refptr<VideoFrame>& frame) : frame_(frame) {
223 DCHECK(frame_.get()); 309 DCHECK(frame_.get());
224 } 310 }
225 ~VideoImageGenerator() override {} 311 ~VideoImageGenerator() override {}
226 312
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 DISALLOW_IMPLICIT_CONSTRUCTORS(VideoImageGenerator); 385 DISALLOW_IMPLICIT_CONSTRUCTORS(VideoImageGenerator);
300 }; 386 };
301 387
302 SkCanvasVideoRenderer::SkCanvasVideoRenderer() 388 SkCanvasVideoRenderer::SkCanvasVideoRenderer()
303 : last_frame_timestamp_(media::kNoTimestamp()), 389 : last_frame_timestamp_(media::kNoTimestamp()),
304 frame_deleting_timer_( 390 frame_deleting_timer_(
305 FROM_HERE, 391 FROM_HERE,
306 base::TimeDelta::FromSeconds(kTemporaryResourceDeletionDelay), 392 base::TimeDelta::FromSeconds(kTemporaryResourceDeletionDelay),
307 this, 393 this,
308 &SkCanvasVideoRenderer::ResetLastFrame), 394 &SkCanvasVideoRenderer::ResetLastFrame),
309 accelerated_generator_(NULL), 395 accelerated_generator_(nullptr),
310 accelerated_last_frame_timestamp_(media::kNoTimestamp()), 396 accelerated_last_frame_timestamp_(media::kNoTimestamp()),
311 accelerated_frame_deleting_timer_( 397 accelerated_frame_deleting_timer_(
312 FROM_HERE, 398 FROM_HERE,
313 base::TimeDelta::FromSeconds(kTemporaryResourceDeletionDelay), 399 base::TimeDelta::FromSeconds(kTemporaryResourceDeletionDelay),
314 this, 400 this,
315 &SkCanvasVideoRenderer::ResetAcceleratedLastFrame) { 401 &SkCanvasVideoRenderer::ResetAcceleratedLastFrame) {
316 last_frame_.setIsVolatile(true); 402 last_frame_.setIsVolatile(true);
317 } 403 }
318 404
319 SkCanvasVideoRenderer::~SkCanvasVideoRenderer() {} 405 SkCanvasVideoRenderer::~SkCanvasVideoRenderer() {}
320 406
321 void SkCanvasVideoRenderer::Paint(const scoped_refptr<VideoFrame>& video_frame, 407 void SkCanvasVideoRenderer::Paint(const scoped_refptr<VideoFrame>& video_frame,
322 SkCanvas* canvas, 408 SkCanvas* canvas,
323 const gfx::RectF& dest_rect, 409 const gfx::RectF& dest_rect,
324 uint8 alpha, 410 uint8 alpha,
325 SkXfermode::Mode mode, 411 SkXfermode::Mode mode,
326 VideoRotation video_rotation) { 412 VideoRotation video_rotation,
413 const Context3DProvider& context_provider) {
327 if (alpha == 0) { 414 if (alpha == 0) {
328 return; 415 return;
329 } 416 }
330 417
331 SkRect dest; 418 SkRect dest;
332 dest.set(dest_rect.x(), dest_rect.y(), dest_rect.right(), dest_rect.bottom()); 419 dest.set(dest_rect.x(), dest_rect.y(), dest_rect.right(), dest_rect.bottom());
333 420
334 SkPaint paint; 421 SkPaint paint;
335 paint.setAlpha(alpha); 422 paint.setAlpha(alpha);
336 423
337 // Paint black rectangle if there isn't a frame available or the 424 // Paint black rectangle if there isn't a frame available or the
338 // frame has an unexpected format. 425 // frame has an unexpected format.
339 if (!video_frame.get() || video_frame->natural_size().IsEmpty() || 426 if (!video_frame.get() || video_frame->natural_size().IsEmpty() ||
340 !IsYUVOrNative(video_frame->format())) { 427 !IsYUVOrNative(video_frame->format())) {
341 canvas->drawRect(dest, paint); 428 canvas->drawRect(dest, paint);
342 canvas->flush(); 429 canvas->flush();
343 return; 430 return;
344 } 431 }
345 432
346 SkBitmap* target_frame = NULL; 433 SkBitmap* target_frame = nullptr;
347 if (canvas->getGrContext()) { 434 if (canvas->getGrContext()) {
435 // TODO(dshwang): Android video decoder doesn't update the timestamp on a
436 // VideoFrame. To reduce redundant copy, Android should update the
437 // timestamp.
348 if (accelerated_last_frame_.isNull() || 438 if (accelerated_last_frame_.isNull() ||
439 #if defined(OS_ANDROID)
440 video_frame->timestamp() == base::TimeDelta() ||
441 #endif
349 video_frame->timestamp() != accelerated_last_frame_timestamp_) { 442 video_frame->timestamp() != accelerated_last_frame_timestamp_) {
350 accelerated_generator_ = new VideoImageGenerator(video_frame); 443 if (video_frame->format() == VideoFrame::NATIVE_TEXTURE) {
444 // Draw HW Video on HW Canvas.
445 DCHECK(context_provider.gl);
446 DCHECK(context_provider.gr_context);
447 DCHECK(!accelerated_generator_);
448 if (!CopyVideoFrameTextureToSkBitmapTexture(video_frame.get(),
449 &accelerated_last_frame_,
450 context_provider)) {
451 NOTREACHED();
452 return;
453 }
454 } else {
455 // Draw SW Video on HW Canvas.
456 accelerated_generator_ = new VideoImageGenerator(video_frame);
351 457
352 // Note: This takes ownership of |accelerated_generator_|. 458 // Note: This takes ownership of |accelerated_generator_|.
353 if (!SkInstallDiscardablePixelRef(accelerated_generator_, 459 if (!SkInstallDiscardablePixelRef(accelerated_generator_,
354 &accelerated_last_frame_)) { 460 &accelerated_last_frame_)) {
355 NOTREACHED(); 461 NOTREACHED();
462 return;
463 }
356 } 464 }
357 DCHECK(video_frame->visible_rect().width() == 465 DCHECK(video_frame->visible_rect().width() ==
358 accelerated_last_frame_.width() && 466 accelerated_last_frame_.width() &&
359 video_frame->visible_rect().height() == 467 video_frame->visible_rect().height() ==
360 accelerated_last_frame_.height()); 468 accelerated_last_frame_.height());
361 469
362 accelerated_last_frame_timestamp_ = video_frame->timestamp(); 470 accelerated_last_frame_timestamp_ = video_frame->timestamp();
363 } else { 471 } else if (accelerated_generator_) {
364 accelerated_generator_->set_frame(video_frame); 472 accelerated_generator_->set_frame(video_frame);
365 } 473 }
366 target_frame = &accelerated_last_frame_; 474 target_frame = &accelerated_last_frame_;
367 accelerated_frame_deleting_timer_.Reset(); 475 accelerated_frame_deleting_timer_.Reset();
368 } else { 476 } else {
369 // Check if we should convert and update |last_frame_|. 477 // Draw both SW and HW Video on SW Canvas.
370 if (last_frame_.isNull() || 478 if (last_frame_.isNull() ||
371 video_frame->timestamp() != last_frame_timestamp_) { 479 video_frame->timestamp() != last_frame_timestamp_) {
372 // Check if |bitmap| needs to be (re)allocated. 480 // Check if |bitmap| needs to be (re)allocated.
373 if (last_frame_.isNull() || 481 if (last_frame_.isNull() ||
374 last_frame_.width() != video_frame->visible_rect().width() || 482 last_frame_.width() != video_frame->visible_rect().width() ||
375 last_frame_.height() != video_frame->visible_rect().height()) { 483 last_frame_.height() != video_frame->visible_rect().height()) {
376 last_frame_.allocN32Pixels(video_frame->visible_rect().width(), 484 last_frame_.allocN32Pixels(video_frame->visible_rect().width(),
377 video_frame->visible_rect().height()); 485 video_frame->visible_rect().height());
378 last_frame_.setIsVolatile(true); 486 last_frame_.setIsVolatile(true);
379 } 487 }
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
427 SkFloatToScalar(rotated_dest_size.height() / target_frame->height())); 535 SkFloatToScalar(rotated_dest_size.height() / target_frame->height()));
428 canvas->translate(-SkFloatToScalar(target_frame->width() * 0.5f), 536 canvas->translate(-SkFloatToScalar(target_frame->width() * 0.5f),
429 -SkFloatToScalar(target_frame->height() * 0.5f)); 537 -SkFloatToScalar(target_frame->height() * 0.5f));
430 } 538 }
431 canvas->drawBitmap(*target_frame, 0, 0, &paint); 539 canvas->drawBitmap(*target_frame, 0, 0, &paint);
432 if (need_transform) 540 if (need_transform)
433 canvas->restore(); 541 canvas->restore();
434 canvas->flush(); 542 canvas->flush();
435 // SkCanvas::flush() causes the generator to generate SkImage, so delete 543 // SkCanvas::flush() causes the generator to generate SkImage, so delete
436 // |video_frame| not to be outlived. 544 // |video_frame| not to be outlived.
437 if (canvas->getGrContext()) 545 if (canvas->getGrContext() && accelerated_generator_)
438 accelerated_generator_->set_frame(NULL); 546 accelerated_generator_->set_frame(nullptr);
439 } 547 }
440 548
441 void SkCanvasVideoRenderer::Copy(const scoped_refptr<VideoFrame>& video_frame, 549 void SkCanvasVideoRenderer::Copy(const scoped_refptr<VideoFrame>& video_frame,
442 SkCanvas* canvas) { 550 SkCanvas* canvas) {
443 Paint(video_frame, 551 Paint(video_frame,
444 canvas, 552 canvas,
445 video_frame->visible_rect(), 553 video_frame->visible_rect(),
446 0xff, 554 0xff,
447 SkXfermode::kSrc_Mode, 555 SkXfermode::kSrc_Mode,
448 media::VIDEO_ROTATION_0); 556 media::VIDEO_ROTATION_0,
557 Context3DProvider());
558 }
559
560 // static
561 void SkCanvasVideoRenderer::CopyVideoFrameTextureToGLTexture(
562 gpu::gles2::GLES2Interface* gl,
563 VideoFrame* video_frame,
564 unsigned int texture,
565 unsigned int level,
566 unsigned int internal_format,
567 unsigned int type,
568 bool premultiply_alpha,
569 bool flip_y) {
570 DCHECK(video_frame && video_frame->format() == VideoFrame::NATIVE_TEXTURE);
571 const gpu::MailboxHolder* mailbox_holder = video_frame->mailbox_holder();
572 DCHECK(mailbox_holder->texture_target == GL_TEXTURE_2D ||
573 mailbox_holder->texture_target == GL_TEXTURE_EXTERNAL_OES);
574
575 gl->WaitSyncPointCHROMIUM(mailbox_holder->sync_point);
576 uint32 source_texture = gl->CreateAndConsumeTextureCHROMIUM(
577 mailbox_holder->texture_target, mailbox_holder->mailbox.name);
578
579 // The video is stored in a unmultiplied format, so premultiply
580 // if necessary.
581 gl->PixelStorei(GL_UNPACK_PREMULTIPLY_ALPHA_CHROMIUM, premultiply_alpha);
582 // Application itself needs to take care of setting the right |flip_y|
583 // value down to get the expected result.
584 // "flip_y == true" means to reverse the video orientation while
585 // "flip_y == false" means to keep the intrinsic orientation.
586 gl->PixelStorei(GL_UNPACK_FLIP_Y_CHROMIUM, flip_y);
587 gl->CopyTextureCHROMIUM(
588 GL_TEXTURE_2D, source_texture, texture, level, internal_format, type);
589 gl->PixelStorei(GL_UNPACK_FLIP_Y_CHROMIUM, false);
590 gl->PixelStorei(GL_UNPACK_PREMULTIPLY_ALPHA_CHROMIUM, false);
591
592 gl->DeleteTextures(1, &source_texture);
593 gl->Flush();
594
595 SyncPointClientImpl client(gl);
596 video_frame->UpdateReleaseSyncPoint(&client);
449 } 597 }
450 598
451 void SkCanvasVideoRenderer::ResetLastFrame() { 599 void SkCanvasVideoRenderer::ResetLastFrame() {
452 last_frame_.reset(); 600 last_frame_.reset();
453 last_frame_timestamp_ = media::kNoTimestamp(); 601 last_frame_timestamp_ = media::kNoTimestamp();
454 } 602 }
455 603
456 void SkCanvasVideoRenderer::ResetAcceleratedLastFrame() { 604 void SkCanvasVideoRenderer::ResetAcceleratedLastFrame() {
457 accelerated_last_frame_.reset(); 605 accelerated_last_frame_.reset();
458 accelerated_generator_ = nullptr; 606 accelerated_generator_ = nullptr;
459 accelerated_last_frame_timestamp_ = media::kNoTimestamp(); 607 accelerated_last_frame_timestamp_ = media::kNoTimestamp();
460 } 608 }
461 609
462 } // namespace media 610 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698