Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 444933002: Use EXPECT_DOUBLE_EQ for floating point comparisons. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer
Modified:
6 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Use EXPECT_DOUBLE_EQ for floating point comparisons. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22917

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M test/base-unittests/platform/time-unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
6 years, 4 months ago (2014-08-06 10:21:19 UTC) #1
Yang
On 2014/08/06 10:21:19, Benedikt Meurer wrote: > PTAL LGTM.
6 years, 4 months ago (2014-08-06 10:21:47 UTC) #2
Benedikt Meurer
6 years, 4 months ago (2014-08-06 10:23:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 22917 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698