Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 444923002: DevTools: Blackboxing out of experiments. (Closed)

Created:
6 years, 4 months ago by aandrey
Modified:
6 years, 4 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Blackboxing out of experiments. BUG=267592 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179844

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -31 lines) Patch
M LayoutTests/http/tests/inspector/debugger-test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/console-log-wrapped-in-framework.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/frameworks-dom-xhr-event-breakpoints.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/frameworks-skip-exceptions.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/frameworks-skip-step-in.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/frameworks-step-from-framework.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/frameworks-steppings.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/frameworks-with-async-callstack.html View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/common/Settings.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/console/ConsoleViewMessage.js View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/DebuggerModel.js View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/Linkifier.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sdk/Script.js View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/devtools/front_end/settings/module.json View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/sources/CallStackSidebarPane.js View 1 2 chunks +1 line, -3 lines 0 comments Download
M Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
aandrey
6 years, 4 months ago (2014-08-06 09:56:35 UTC) #1
aandrey
Reminder: needs rebaseline after https://codereview.chromium.org/443943002/ landed
6 years, 4 months ago (2014-08-06 11:39:55 UTC) #2
aandrey
Reminder: also needs rebaseline after https://codereview.chromium.org/448743002/
6 years, 4 months ago (2014-08-06 16:10:41 UTC) #3
pfeldman
lgtm
6 years, 4 months ago (2014-08-08 13:17:27 UTC) #4
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 4 months ago (2014-08-08 15:02:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/444923002/20001
6 years, 4 months ago (2014-08-08 15:03:12 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 17:03:15 UTC) #7
Message was sent while issue was closed.
Change committed as 179844

Powered by Google App Engine
This is Rietveld 408576698