[cros] user_manager component - move UserManagerBase and UserManager

components/user_manager/user_manager_base.cc

Index: components/user_manager/user_manager_base.cc
diff --git a/chrome/browser/chromeos/login/users/user_manager_base.cc b/components/user_manager/user_manager_base.cc
similarity index 80%
rename from chrome/browser/chromeos/login/users/user_manager_base.cc
rename to components/user_manager/user_manager_base.cc
index d2d42e428e59718baa805cacdce898753ed13651..7c050a8b39458e51b9d9eb71cc953f7ab654acab 100644
--- a/chrome/browser/chromeos/login/users/user_manager_base.cc
+++ b/components/user_manager/user_manager_base.cc
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/browser/chromeos/login/users/user_manager_base.h"
+#include "components/user_manager/user_manager_base.h"
 
 #include <cstddef>
 #include <set>
@@ -21,12 +21,12 @@
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
-#include "chrome/browser/chromeos/login/users/remove_user_delegate.h"
 #include "chromeos/chromeos_switches.h"
 #include "chromeos/cryptohome/async_method_caller.h"
 #include "chromeos/login/login_state.h"
 #include "chromeos/login/user_names.h"
 #include "components/session_manager/core/session_manager.h"
+#include "components/user_manager/remove_user_delegate.h"
 #include "components/user_manager/user_type.h"
 #include "content/public/browser/browser_thread.h"
 #include "google_apis/gaia/gaia_auth_util.h"
@@ -34,7 +34,7 @@
 
 using content::BrowserThread;
 
-namespace chromeos {
+namespace user_manager {
 namespace {
 
 // A vector pref of the the regular users known on this device, arranged in LRU
@@ -115,14 +115,12 @@ UserManagerBase::UserManagerBase()
       ephemeral_users_enabled_(false),
       manager_creation_time_(base::TimeTicks::Now()),
       weak_factory_(this) {
-  // UserManager instance should be used only on UI thread.
-  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

[Dmitry Polukhin, 2014/08/12 09:03:13]

Why did you remove it?

[Nikita (slow), 2014/08/12 09:34:42]

unit_tests now use this class through

FakeUserManager|MockUserManager > ChromeUserManager > UserManagerBase >
UserManager

instead of previous

FakeUserManager|MockUserManager > UserManager.

unit_tests don't have browser threads creating so this check fails. We do have
these checks in ChromeUserManager methods though.

   UpdateLoginState();
 }
 
 UserManagerBase::~UserManagerBase() {
   // Can't use STLDeleteElements because of the private destructor of User.
-  for (user_manager::UserList::iterator it = users_.begin(); it != users_.end();
+  for (UserList::iterator it = users_.begin(); it != users_.end();
        it = users_.erase(it)) {
     DeleteUser(*it);
   }
@@ -137,16 +135,16 @@ void UserManagerBase::Shutdown() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 }
 
-const user_manager::UserList& UserManagerBase::GetUsers() const {
+const UserList& UserManagerBase::GetUsers() const {
   const_cast<UserManagerBase*>(this)->EnsureUsersLoaded();
   return users_;
 }
 
-const user_manager::UserList& UserManagerBase::GetLoggedInUsers() const {
+const UserList& UserManagerBase::GetLoggedInUsers() const {
   return logged_in_users_;
 }
 
-const user_manager::UserList& UserManagerBase::GetLRULoggedInUsers() const {
+const UserList& UserManagerBase::GetLRULoggedInUsers() const {
   return lru_logged_in_users_;
 }
 
@@ -159,7 +157,7 @@ void UserManagerBase::UserLoggedIn(const std::string& user_id,
                                    bool browser_restart) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
-  user_manager::User* user = FindUserInListAndModify(user_id);
+  User* user = FindUserInListAndModify(user_id);
   if (active_user_ && user) {
     user->set_is_logged_in(true);
     user->set_username_hash(username_hash);
@@ -184,17 +182,15 @@ void UserManagerBase::UserLoggedIn(const std::string& user_id,
   } else {
     EnsureUsersLoaded();
 
-    if (user && user->GetType() == user_manager::USER_TYPE_PUBLIC_ACCOUNT) {
+    if (user && user->GetType() == USER_TYPE_PUBLIC_ACCOUNT) {
       PublicAccountUserLoggedIn(user);
-    } else if ((user &&
-                user->GetType() == user_manager::USER_TYPE_SUPERVISED) ||
+    } else if ((user && user->GetType() == USER_TYPE_SUPERVISED) ||
                (!user &&
                 gaia::ExtractDomainName(user_id) ==
                     chromeos::login::kSupervisedUserDomain)) {
       SupervisedUserLoggedIn(user_id);
     } else if (browser_restart && IsPublicAccountMarkedForRemoval(user_id)) {
-      PublicAccountUserLoggedIn(
-          user_manager::User::CreatePublicAccountUser(user_id));
+      PublicAccountUserLoggedIn(User::CreatePublicAccountUser(user_id));
     } else if (user_id != GetOwnerEmail() && !user &&
                (AreEphemeralUsersEnabled() || browser_restart)) {
       RegularUserLoggedInAsEphemeral(user_id);
@@ -214,25 +210,23 @@ void UserManagerBase::UserLoggedIn(const std::string& user_id,
 
   if (!primary_user_) {
     primary_user_ = active_user_;
-    if (primary_user_->GetType() == user_manager::USER_TYPE_REGULAR)
+    if (primary_user_->GetType() == USER_TYPE_REGULAR)
       SendRegularUserLoginMetrics(user_id);
   }
 
-  UMA_HISTOGRAM_ENUMERATION("UserManager.LoginUserType",
-                            active_user_->GetType(),
-                            user_manager::NUM_USER_TYPES);
+  UMA_HISTOGRAM_ENUMERATION(
+      "UserManager.LoginUserType", active_user_->GetType(), NUM_USER_TYPES);
 
   GetLocalState()->SetString(
       kLastLoggedInRegularUser,
-      (active_user_->GetType() == user_manager::USER_TYPE_REGULAR) ? user_id
-                                                                   : "");
+      (active_user_->GetType() == USER_TYPE_REGULAR) ? user_id : "");
 
   NotifyOnLogin();
   PerformPostUserLoggedInActions(browser_restart);
 }
 
 void UserManagerBase::SwitchActiveUser(const std::string& user_id) {
-  user_manager::User* user = FindUserAndModify(user_id);
+  User* user = FindUserAndModify(user_id);
   if (!user) {
     NOTREACHED() << "Switching to a non-existing user";
     return;
@@ -245,7 +239,7 @@ void UserManagerBase::SwitchActiveUser(const std::string& user_id) {
     NOTREACHED() << "Switching to a user that is not logged in";
     return;
   }
-  if (user->GetType() != user_manager::USER_TYPE_REGULAR) {
+  if (user->GetType() != USER_TYPE_REGULAR) {
     NOTREACHED() << "Switching to a non-regular user";
     return;
   }
@@ -332,54 +326,52 @@ bool UserManagerBase::IsKnownUser(const std::string& user_id) const {
   return FindUser(user_id) != NULL;
 }
 
-const user_manager::User* UserManagerBase::FindUser(
-    const std::string& user_id) const {
+const User* UserManagerBase::FindUser(const std::string& user_id) const {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   if (active_user_ && active_user_->email() == user_id)
     return active_user_;
   return FindUserInList(user_id);
 }
 
-user_manager::User* UserManagerBase::FindUserAndModify(
-    const std::string& user_id) {
+User* UserManagerBase::FindUserAndModify(const std::string& user_id) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   if (active_user_ && active_user_->email() == user_id)
     return active_user_;
   return FindUserInListAndModify(user_id);
 }
 
-const user_manager::User* UserManagerBase::GetLoggedInUser() const {
+const User* UserManagerBase::GetLoggedInUser() const {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   return active_user_;
 }
 
-user_manager::User* UserManagerBase::GetLoggedInUser() {
+User* UserManagerBase::GetLoggedInUser() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   return active_user_;
 }
 
-const user_manager::User* UserManagerBase::GetActiveUser() const {
+const User* UserManagerBase::GetActiveUser() const {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   return active_user_;
 }
 
-user_manager::User* UserManagerBase::GetActiveUser() {
+User* UserManagerBase::GetActiveUser() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   return active_user_;
 }
 
-const user_manager::User* UserManagerBase::GetPrimaryUser() const {
+const User* UserManagerBase::GetPrimaryUser() const {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   return primary_user_;
 }
 
 void UserManagerBase::SaveUserOAuthStatus(
     const std::string& user_id,
-    user_manager::User::OAuthTokenStatus oauth_token_status) {
+    User::OAuthTokenStatus oauth_token_status) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   DVLOG(1) << "Saving user OAuth token status in Local State";
-  user_manager::User* user = FindUserAndModify(user_id);
+  User* user = FindUserAndModify(user_id);
   if (user)
     user->set_oauth_token_status(oauth_token_status);
 
@@ -414,7 +406,7 @@ void UserManagerBase::SaveUserDisplayName(const std::string& user_id,
                                           const base::string16& display_name) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
-  if (user_manager::User* user = FindUserAndModify(user_id)) {
+  if (User* user = FindUserAndModify(user_id)) {
     user->set_display_name(display_name);
 
     // Do not update local state if data stored or cached outside the user's
@@ -430,7 +422,7 @@ void UserManagerBase::SaveUserDisplayName(const std::string& user_id,
 
 base::string16 UserManagerBase::GetUserDisplayName(
     const std::string& user_id) const {
-  const user_manager::User* user = FindUser(user_id);
+  const User* user = FindUser(user_id);
   return user ? user->display_name() : base::string16();
 }
 
@@ -438,7 +430,7 @@ void UserManagerBase::SaveUserDisplayEmail(const std::string& user_id,
                                            const std::string& display_email) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
-  user_manager::User* user = FindUserAndModify(user_id);
+  User* user = FindUserAndModify(user_id);
   if (!user)
     return;  // Ignore if there is no such user.
 
@@ -456,7 +448,7 @@ void UserManagerBase::SaveUserDisplayEmail(const std::string& user_id,
 
 std::string UserManagerBase::GetUserDisplayEmail(
     const std::string& user_id) const {
-  const user_manager::User* user = FindUser(user_id);
+  const User* user = FindUser(user_id);
   return user ? user->display_email() : user_id;
 }
 
@@ -467,7 +459,7 @@ void UserManagerBase::UpdateUserAccountData(
 
   SaveUserDisplayName(user_id, account_data.display_name());
 
-  if (user_manager::User* user = FindUserAndModify(user_id)) {
+  if (User* user = FindUserAndModify(user_id)) {
     base::string16 given_name = account_data.given_name();
     user->set_given_name(given_name);
     if (!IsUserNonCryptohomeDataEphemeral(user_id)) {
@@ -540,43 +532,39 @@ bool UserManagerBase::IsUserLoggedIn() const {
 
 bool UserManagerBase::IsLoggedInAsRegularUser() const {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-  return IsUserLoggedIn() &&
-         active_user_->GetType() == user_manager::USER_TYPE_REGULAR;
+  return IsUserLoggedIn() && active_user_->GetType() == USER_TYPE_REGULAR;
 }
 
 bool UserManagerBase::IsLoggedInAsDemoUser() const {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-  return IsUserLoggedIn() &&
-         active_user_->GetType() == user_manager::USER_TYPE_RETAIL_MODE;
+  return IsUserLoggedIn() && active_user_->GetType() == USER_TYPE_RETAIL_MODE;
 }
 
 bool UserManagerBase::IsLoggedInAsPublicAccount() const {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   return IsUserLoggedIn() &&
-         active_user_->GetType() == user_manager::USER_TYPE_PUBLIC_ACCOUNT;
+         active_user_->GetType() == USER_TYPE_PUBLIC_ACCOUNT;
 }
 
 bool UserManagerBase::IsLoggedInAsGuest() const {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-  return IsUserLoggedIn() &&
-         active_user_->GetType() == user_manager::USER_TYPE_GUEST;
+  return IsUserLoggedIn() && active_user_->GetType() == USER_TYPE_GUEST;
 }
 
 bool UserManagerBase::IsLoggedInAsSupervisedUser() const {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-  return IsUserLoggedIn() &&
-         active_user_->GetType() == user_manager::USER_TYPE_SUPERVISED;
+  return IsUserLoggedIn() && active_user_->GetType() == USER_TYPE_SUPERVISED;
 }
 
 bool UserManagerBase::IsLoggedInAsKioskApp() const {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-  return IsUserLoggedIn() &&
-         active_user_->GetType() == user_manager::USER_TYPE_KIOSK_APP;
+  return IsUserLoggedIn() && active_user_->GetType() == USER_TYPE_KIOSK_APP;
 }
 
 bool UserManagerBase::IsLoggedInAsStub() const {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-  return IsUserLoggedIn() && active_user_->email() == login::kStubUser;
+  return IsUserLoggedIn() &&
+         active_user_->email() == chromeos::login::kStubUser;
 }
 
 bool UserManagerBase::IsSessionStarted() const {
@@ -588,8 +576,9 @@ bool UserManagerBase::IsUserNonCryptohomeDataEphemeral(
     const std::string& user_id) const {
   // Data belonging to the guest, retail mode and stub users is always
   // ephemeral.
-  if (user_id == login::kGuestUserName ||
-      user_id == login::kRetailModeUserName || user_id == login::kStubUser) {
+  if (user_id == chromeos::login::kGuestUserName ||
+      user_id == chromeos::login::kRetailModeUserName ||
+      user_id == chromeos::login::kStubUser) {
     return true;
   }
 
@@ -647,10 +636,10 @@ void UserManagerBase::NotifyLocalStateChanged() {
       UserManager::Observer, observer_list_, LocalStateChanged(this));
 }
 
-bool UserManagerBase::CanUserBeRemoved(const user_manager::User* user) const {
+bool UserManagerBase::CanUserBeRemoved(const User* user) const {
   // Only regular and supervised users are allowed to be manually removed.
-  if (!user || (user->GetType() != user_manager::USER_TYPE_REGULAR &&
-                user->GetType() != user_manager::USER_TYPE_SUPERVISED)) {
+  if (!user || (user->GetType() != USER_TYPE_REGULAR &&
+                user->GetType() != USER_TYPE_SUPERVISED)) {
     return false;
   }
 
@@ -664,7 +653,7 @@ bool UserManagerBase::CanUserBeRemoved(const user_manager::User* user) const {
     return false;
 
   // Sanity check: do not allow any of the the logged in users to be removed.
-  for (user_manager::UserList::const_iterator it = logged_in_users_.begin();
+  for (UserList::const_iterator it = logged_in_users_.begin();
        it != logged_in_users_.end();
        ++it) {
     if ((*it)->email() == user->email())
@@ -734,12 +723,12 @@ void UserManagerBase::EnsureUsersLoaded() {
   for (std::vector<std::string>::const_iterator it = regular_users.begin();
        it != regular_users.end();
        ++it) {
-    user_manager::User* user = NULL;
+    User* user = NULL;
     const std::string domain = gaia::ExtractDomainName(*it);
     if (domain == chromeos::login::kSupervisedUserDomain)
-      user = user_manager::User::CreateSupervisedUser(*it);
+      user = User::CreateSupervisedUser(*it);
     else
-      user = user_manager::User::CreateRegularUser(*it);
+      user = User::CreateRegularUser(*it);
     user->set_oauth_token_status(LoadUserOAuthStatus(*it));
     user->set_force_online_signin(LoadForceOnlineSignin(*it));
     users_.push_back(user);
@@ -767,17 +756,14 @@ void UserManagerBase::EnsureUsersLoaded() {
   PerformPostUserListLoadingActions();
 }
 
-user_manager::UserList& UserManagerBase::GetUsersAndModify() {
+UserList& UserManagerBase::GetUsersAndModify() {
   EnsureUsersLoaded();
   return users_;
 }
 
-const user_manager::User* UserManagerBase::FindUserInList(
-    const std::string& user_id) const {
-  const user_manager::UserList& users = GetUsers();
-  for (user_manager::UserList::const_iterator it = users.begin();
-       it != users.end();
-       ++it) {
+const User* UserManagerBase::FindUserInList(const std::string& user_id) const {
+  const UserList& users = GetUsers();
+  for (UserList::const_iterator it = users.begin(); it != users.end(); ++it) {
     if ((*it)->email() == user_id)
       return *it;
   }
@@ -794,11 +780,9 @@ const bool UserManagerBase::UserExistsInList(const std::string& user_id) const {
   return false;
 }
 
-user_manager::User* UserManagerBase::FindUserInListAndModify(
-    const std::string& user_id) {
-  user_manager::UserList& users = GetUsersAndModify();
-  for (user_manager::UserList::iterator it = users.begin(); it != users.end();
-       ++it) {
+User* UserManagerBase::FindUserInListAndModify(const std::string& user_id) {
+  UserList& users = GetUsersAndModify();
+  for (UserList::iterator it = users.begin(); it != users.end(); ++it) {
     if ((*it)->email() == user_id)
       return *it;
   }
@@ -807,10 +791,10 @@ user_manager::User* UserManagerBase::FindUserInListAndModify(
 
 void UserManagerBase::GuestUserLoggedIn() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-  active_user_ = user_manager::User::CreateGuestUser();
+  active_user_ = User::CreateGuestUser();
 }
 
-void UserManagerBase::AddUserRecord(user_manager::User* user) {
+void UserManagerBase::AddUserRecord(User* user) {
   // Add the user to the front of the user list.
   ListPrefUpdate prefs_users_update(GetLocalState(), kRegularUsers);
   prefs_users_update->Insert(0, new base::StringValue(user->email()));
@@ -824,7 +808,7 @@ void UserManagerBase::RegularUserLoggedIn(const std::string& user_id) {
   // If the user was not found on the user list, create a new user.
   SetIsCurrentUserNew(!active_user_);
   if (IsCurrentUserNew()) {
-    active_user_ = user_manager::User::CreateRegularUser(user_id);
+    active_user_ = User::CreateRegularUser(user_id);
     active_user_->set_oauth_token_status(LoadUserOAuthStatus(user_id));
     SaveUserDisplayName(active_user_->email(),
                         base::UTF8ToUTF16(active_user_->GetAccountName(true)));
@@ -841,7 +825,7 @@ void UserManagerBase::RegularUserLoggedInAsEphemeral(
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   SetIsCurrentUserNew(true);
   is_current_user_ephemeral_regular_user_ = true;
-  active_user_ = user_manager::User::CreateRegularUser(user_id);
+  active_user_ = User::CreateRegularUser(user_id);
 }
 
 void UserManagerBase::NotifyOnLogin() {
@@ -852,23 +836,23 @@ void UserManagerBase::NotifyOnLogin() {
   UpdateLoginState();
 }
 
-user_manager::User::OAuthTokenStatus UserManagerBase::LoadUserOAuthStatus(
+User::OAuthTokenStatus UserManagerBase::LoadUserOAuthStatus(
     const std::string& user_id) const {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   const base::DictionaryValue* prefs_oauth_status =
       GetLocalState()->GetDictionary(kUserOAuthTokenStatus);
-  int oauth_token_status = user_manager::User::OAUTH_TOKEN_STATUS_UNKNOWN;
+  int oauth_token_status = User::OAUTH_TOKEN_STATUS_UNKNOWN;
   if (prefs_oauth_status &&
       prefs_oauth_status->GetIntegerWithoutPathExpansion(user_id,
                                                          &oauth_token_status)) {
-    user_manager::User::OAuthTokenStatus result =
-        static_cast<user_manager::User::OAuthTokenStatus>(oauth_token_status);
-    if (result == user_manager::User::OAUTH2_TOKEN_STATUS_INVALID)
-      GetUserFlow(user_id)->HandleOAuthTokenStatusChange(result);
-    return result;
+    User::OAuthTokenStatus status =
+        static_cast<User::OAuthTokenStatus>(oauth_token_status);
+    HandleUserOAuthTokenStatusChange(user_id, status);
+
+    return status;
   }
-  return user_manager::User::OAUTH_TOKEN_STATUS_UNKNOWN;
+  return User::OAUTH_TOKEN_STATUS_UNKNOWN;
 }
 
 bool UserManagerBase::LoadForceOnlineSignin(const std::string& user_id) const {
@@ -902,20 +886,19 @@ void UserManagerBase::RemoveNonCryptohomeData(const std::string& user_id) {
   prefs_force_online_update->RemoveWithoutPathExpansion(user_id, NULL);
 }
 
-user_manager::User* UserManagerBase::RemoveRegularOrSupervisedUserFromList(
+User* UserManagerBase::RemoveRegularOrSupervisedUserFromList(
     const std::string& user_id) {
   ListPrefUpdate prefs_users_update(GetLocalState(), kRegularUsers);
   prefs_users_update->Clear();
-  user_manager::User* user = NULL;
-  for (user_manager::UserList::iterator it = users_.begin();
-       it != users_.end();) {
+  User* user = NULL;
+  for (UserList::iterator it = users_.begin(); it != users_.end();) {
     const std::string user_email = (*it)->email();
     if (user_email == user_id) {
       user = *it;
       it = users_.erase(it);
     } else {
-      if ((*it)->GetType() == user_manager::USER_TYPE_REGULAR ||
-          (*it)->GetType() == user_manager::USER_TYPE_SUPERVISED) {
+      if ((*it)->GetType() == USER_TYPE_REGULAR ||
+          (*it)->GetType() == USER_TYPE_SUPERVISED) {
         prefs_users_update->Append(new base::StringValue(user_email));
       }
       ++it;
@@ -924,17 +907,15 @@ user_manager::User* UserManagerBase::RemoveRegularOrSupervisedUserFromList(
   return user;
 }
 
-void UserManagerBase::NotifyActiveUserChanged(
-    const user_manager::User* active_user) {
+void UserManagerBase::NotifyActiveUserChanged(const User* active_user) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   FOR_EACH_OBSERVER(UserManager::UserSessionStateObserver,
                     session_state_observer_list_,
                     ActiveUserChanged(active_user));
 }
 
-void UserManagerBase::NotifyUserAddedToSession(
-    const user_manager::User* added_user,
-    bool user_switch_pending) {
+void UserManagerBase::NotifyUserAddedToSession(const User* added_user,
+                                               bool user_switch_pending) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   FOR_EACH_OBSERVER(UserManager::UserSessionStateObserver,
                     session_state_observer_list_,
@@ -949,41 +930,42 @@ void UserManagerBase::NotifyActiveUserHashChanged(const std::string& hash) {
 }
 
 void UserManagerBase::UpdateLoginState() {
-  if (!LoginState::IsInitialized())
+  if (!chromeos::LoginState::IsInitialized())
     return;  // LoginState may not be intialized in tests.
 
-  LoginState::LoggedInState logged_in_state;
-  logged_in_state =
-      active_user_ ? LoginState::LOGGED_IN_ACTIVE : LoginState::LOGGED_IN_NONE;
+  chromeos::LoginState::LoggedInState logged_in_state;
+  logged_in_state = active_user_ ? chromeos::LoginState::LOGGED_IN_ACTIVE
+                                 : chromeos::LoginState::LOGGED_IN_NONE;
 
-  LoginState::LoggedInUserType login_user_type;
-  if (logged_in_state == LoginState::LOGGED_IN_NONE)
-    login_user_type = LoginState::LOGGED_IN_USER_NONE;
+  chromeos::LoginState::LoggedInUserType login_user_type;
+  if (logged_in_state == chromeos::LoginState::LOGGED_IN_NONE)
+    login_user_type = chromeos::LoginState::LOGGED_IN_USER_NONE;
   else if (is_current_user_owner_)
-    login_user_type = LoginState::LOGGED_IN_USER_OWNER;
-  else if (active_user_->GetType() == user_manager::USER_TYPE_GUEST)
-    login_user_type = LoginState::LOGGED_IN_USER_GUEST;
-  else if (active_user_->GetType() == user_manager::USER_TYPE_RETAIL_MODE)
-    login_user_type = LoginState::LOGGED_IN_USER_RETAIL_MODE;
-  else if (active_user_->GetType() == user_manager::USER_TYPE_PUBLIC_ACCOUNT)
-    login_user_type = LoginState::LOGGED_IN_USER_PUBLIC_ACCOUNT;
-  else if (active_user_->GetType() == user_manager::USER_TYPE_SUPERVISED)
-    login_user_type = LoginState::LOGGED_IN_USER_SUPERVISED;
-  else if (active_user_->GetType() == user_manager::USER_TYPE_KIOSK_APP)
-    login_user_type = LoginState::LOGGED_IN_USER_KIOSK_APP;
+    login_user_type = chromeos::LoginState::LOGGED_IN_USER_OWNER;
+  else if (active_user_->GetType() == USER_TYPE_GUEST)
+    login_user_type = chromeos::LoginState::LOGGED_IN_USER_GUEST;
+  else if (active_user_->GetType() == USER_TYPE_RETAIL_MODE)
+    login_user_type = chromeos::LoginState::LOGGED_IN_USER_RETAIL_MODE;
+  else if (active_user_->GetType() == USER_TYPE_PUBLIC_ACCOUNT)
+    login_user_type = chromeos::LoginState::LOGGED_IN_USER_PUBLIC_ACCOUNT;
+  else if (active_user_->GetType() == USER_TYPE_SUPERVISED)
+    login_user_type = chromeos::LoginState::LOGGED_IN_USER_SUPERVISED;
+  else if (active_user_->GetType() == USER_TYPE_KIOSK_APP)
+    login_user_type = chromeos::LoginState::LOGGED_IN_USER_KIOSK_APP;
   else
-    login_user_type = LoginState::LOGGED_IN_USER_REGULAR;
+    login_user_type = chromeos::LoginState::LOGGED_IN_USER_REGULAR;
 
   if (primary_user_) {
-    LoginState::Get()->SetLoggedInStateAndPrimaryUser(
+    chromeos::LoginState::Get()->SetLoggedInStateAndPrimaryUser(
         logged_in_state, login_user_type, primary_user_->username_hash());
   } else {
-    LoginState::Get()->SetLoggedInState(logged_in_state, login_user_type);
+    chromeos::LoginState::Get()->SetLoggedInState(logged_in_state,
+                                                  login_user_type);
   }
 }
 
-void UserManagerBase::SetLRUUser(user_manager::User* user) {
-  user_manager::UserList::iterator it =
+void UserManagerBase::SetLRUUser(User* user) {
+  UserList::iterator it =
       std::find(lru_logged_in_users_.begin(), lru_logged_in_users_.end(), user);
   if (it != lru_logged_in_users_.end())
     lru_logged_in_users_.erase(it);
@@ -994,7 +976,7 @@ void UserManagerBase::SendRegularUserLoginMetrics(const std::string& user_id) {
   // If this isn't the first time Chrome was run after the system booted,
   // assume that Chrome was restarted because a previous session ended.
   if (!CommandLine::ForCurrentProcess()->HasSwitch(
-          switches::kFirstExecAfterBoot)) {
+          chromeos::switches::kFirstExecAfterBoot)) {
     const std::string last_email =
         GetLocalState()->GetString(kLastLoggedInRegularUser);
     const base::TimeDelta time_to_login =
@@ -1017,10 +999,8 @@ void UserManagerBase::UpdateUserAccountLocale(const std::string& user_id,
         base::Bind(&UserManagerBase::DoUpdateAccountLocale,
                    weak_factory_.GetWeakPtr(),
                    user_id);
-    BrowserThread::PostBlockingPoolTask(FROM_HERE,
-                                        base::Bind(ResolveLocale,
-                                                   locale,
-                                                   on_resolve_callback));
+    BrowserThread::PostBlockingPoolTask(
+        FROM_HERE, base::Bind(ResolveLocale, locale, on_resolve_callback));
   } else {
     DoUpdateAccountLocale(user_id, locale);
   }
@@ -1029,15 +1009,15 @@ void UserManagerBase::UpdateUserAccountLocale(const std::string& user_id,
 void UserManagerBase::DoUpdateAccountLocale(
     const std::string& user_id,
     const std::string& resolved_locale) {
-  if (user_manager::User* user = FindUserAndModify(user_id))
+  if (User* user = FindUserAndModify(user_id))
     user->SetAccountLocale(resolved_locale);
 }
 
-void UserManagerBase::DeleteUser(user_manager::User* user) {
+void UserManagerBase::DeleteUser(User* user) {
   const bool is_active_user = (user == active_user_);
   delete user;
   if (is_active_user)
     active_user_ = NULL;
 }
 
-}  // namespace chromeos
+}  // namespace user_manager