Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 444883004: [DevTools] Make inspector-protocol tests work with messages passed as objects. (Closed)

Created:
6 years, 4 months ago by dgozman
Modified:
6 years, 4 months ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[DevTools] Make inspector-protocol tests work with messages passed as objects. This mirrors the real inspector frontend logic, where we already get objects instead of strings. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179619

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dgozman
Take a look please.
6 years, 4 months ago (2014-08-06 09:29:09 UTC) #1
vsevik
lgtm
6 years, 4 months ago (2014-08-06 09:29:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/444883004/1
6 years, 4 months ago (2014-08-06 09:31:22 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-06 12:15:16 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 12:41:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/20038)
6 years, 4 months ago (2014-08-06 12:41:40 UTC) #6
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 4 months ago (2014-08-06 12:49:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/444883004/1
6 years, 4 months ago (2014-08-06 12:50:11 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-06 14:07:02 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 15:20:55 UTC) #10
Message was sent while issue was closed.
Change committed as 179619

Powered by Google App Engine
This is Rietveld 408576698