Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 444863002: Updated FeatureObserver histograms (Closed)

Created:
6 years, 4 months ago by Mike Lawther (Google)
Modified:
6 years, 4 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Updated FeatureObserver histograms. This was done using the scripts in tools/metrics/histograms. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288937

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Mike Lawther (Google)
6 years, 4 months ago (2014-08-06 04:58:02 UTC) #1
Ilya Sherman
LGTM. Thanks for running the scripts :)
6 years, 4 months ago (2014-08-06 17:16:57 UTC) #2
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 4 months ago (2014-08-06 17:18:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikelawther@chromium.org/444863002/1
6 years, 4 months ago (2014-08-06 17:18:54 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 17:19:52 UTC) #5
commit-bot: I haz the power
Failed to apply patch for tools/metrics/histograms/histograms.xml: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 4 months ago (2014-08-06 17:19:53 UTC) #6
Mike Lawther (Google)
Looks like this collided with https://codereview.chromium.org/442773002.
6 years, 4 months ago (2014-08-12 06:51:49 UTC) #7
Mike Lawther (Google)
The CQ bit was checked by mikelawther@chromium.org
6 years, 4 months ago (2014-08-12 06:51:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikelawther@chromium.org/444863002/20001
6 years, 4 months ago (2014-08-12 06:53:15 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 11:54:29 UTC) #10
Message was sent while issue was closed.
Change committed as 288937

Powered by Google App Engine
This is Rietveld 408576698