chrome/browser/prefs/chrome_pref_service_unittest.cc - Issue 444843002: Cache the current WebPreferences on RenderViewHostImpl (try #2).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/chrome_pref_service_unittest.cc

Issue 444843002: Cache the current WebPreferences on RenderViewHostImpl (try #2). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added defensive code. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/prefs/chrome_pref_service_unittest.cc

diff --git a/chrome/browser/prefs/chrome_pref_service_unittest.cc b/chrome/browser/prefs/chrome_pref_service_unittest.cc

index 67a77a4ee5a755d800a2cec8396c342172eabbe6..4b6494637e6063a0d8688fcb70e15f0476d503d2 100644

--- a/chrome/browser/prefs/chrome_pref_service_unittest.cc

+++ b/chrome/browser/prefs/chrome_pref_service_unittest.cc

@@ -117,7 +117,7 @@ class ChromePrefServiceWebKitPrefs : public ChromeRenderViewHostTestHarness {

// to a WebPreferences object.

TEST_F(ChromePrefServiceWebKitPrefs, PrefsCopied) {

WebPreferences webkit_prefs =

- WebContentsTester::For(web_contents())->TestGetWebkitPrefs();

+ WebContentsTester::For(web_contents())->TestComputeWebkitPrefs();

// These values have been overridden by the profile preferences.

EXPECT_EQ("UTF-8", webkit_prefs.default_encoding);