android_webview/native/aw_settings.cc - Issue 444843002: Cache the current WebPreferences on RenderViewHostImpl (try #2).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_settings.cc

Issue 444843002: Cache the current WebPreferences on RenderViewHostImpl (try #2). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added defensive code. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/native/aw_settings.cc

diff --git a/android_webview/native/aw_settings.cc b/android_webview/native/aw_settings.cc

index e9ba10ee2b678b354edc1f148e191f58fca07115..2a0a50b39d64ce137da834bcd9aedc9fd16e4c3a 100644

--- a/android_webview/native/aw_settings.cc

+++ b/android_webview/native/aw_settings.cc

@@ -158,8 +158,7 @@ void AwSettings::UpdateWebkitPreferencesLocked(JNIEnv* env, jobject obj) {

content::RenderViewHost* render_view_host =

web_contents()->GetRenderViewHost();

if (!render_view_host) return;

- render_view_host->UpdateWebkitPreferences(

- render_view_host->GetWebkitPreferences());

+ render_view_host->OnWebkitPreferencesChanged();

}

void AwSettings::UpdateInitialPageScaleLocked(JNIEnv* env, jobject obj) {