chrome/browser/printing/print_dialog_cloud.cc - Issue 444843002: Cache the current WebPreferences on RenderViewHostImpl (try #2).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_dialog_cloud.cc

Issue 444843002: Cache the current WebPreferences on RenderViewHostImpl (try #2). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/printing/print_dialog_cloud.cc

diff --git a/chrome/browser/printing/print_dialog_cloud.cc b/chrome/browser/printing/print_dialog_cloud.cc

index 9269c7f7d3af0e690a819cd991e93748eccd1443..d0e67d2e964562889e9687ab3a04b6aff121fba3 100644

--- a/chrome/browser/printing/print_dialog_cloud.cc

+++ b/chrome/browser/printing/print_dialog_cloud.cc

@@ -361,6 +361,8 @@ void CloudPrintFlowHandler::Observe(

// script permissions required for the web UI.

RenderViewHost* rvh = web_ui()->GetWebContents()->GetRenderViewHost();

if (rvh) {

+ // TODO(chrishtr): this is wrong. allow_scripts_to_close_windows will

+ // be reset the next time a preference changes.

WebPreferences webkit_prefs = rvh->GetWebkitPreferences();

webkit_prefs.allow_scripts_to_close_windows = true;

rvh->UpdateWebkitPreferences(webkit_prefs);