Plumb allow_overlay flag to parent compositor.

Plumb allow_overlay flag to parent compositor.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287939

[alexst (slow to review), 2014-08-05 22:34:33]

We marked resources that can be overlayed in hardware as such in the renderer,
but did not properly plumb that flag across IPC to the browser process that
actually needs to use it.

[danakj, 2014-08-06 14:13:43]

LGTM w/ nits

https://codereview.chromium.org/444823002/diff/1/cc/resources/resource_provid...
File cc/resources/resource_provider_unittest.cc (right):

https://codereview.chromium.org/444823002/diff/1/cc/resources/resource_provid...
cc/resources/resource_provider_unittest.cc:880: void MailboxReleased(unsigned
sync_point, bool lost_resource) {
There's EmptyReleaseCallback at the top of this file you can use.

https://codereview.chromium.org/444823002/diff/1/cc/resources/resource_provid...
cc/resources/resource_provider_unittest.cc:884: if (GetParam() !=
ResourceProvider::GLTexture)
Add a comment explaining why please

https://codereview.chromium.org/444823002/diff/1/cc/resources/resource_provid...
cc/resources/resource_provider_unittest.cc:887: unsigned sync_point = 0;
nit: can you uint32 for this? someone previously went to the trouble to make
those consistent for sync points as uint32s

https://codereview.chromium.org/444823002/diff/1/cc/resources/resource_provid...
cc/resources/resource_provider_unittest.cc:889:
TextureMailbox(gpu::Mailbox::Generate(), GL_TEXTURE_2D, sync_point);
nit: drop the "= TextureMailbox"

[alexst (slow to review), 2014-08-06 14:59:38]

On 2014/08/06 14:13:43, danakj wrote:
> LGTM w/ nits
> 
>
https://codereview.chromium.org/444823002/diff/1/cc/resources/resource_provid...
> File cc/resources/resource_provider_unittest.cc (right):
> 
>
https://codereview.chromium.org/444823002/diff/1/cc/resources/resource_provid...
> cc/resources/resource_provider_unittest.cc:880: void MailboxReleased(unsigned
> sync_point, bool lost_resource) {
> There's EmptyReleaseCallback at the top of this file you can use.
> 
>
https://codereview.chromium.org/444823002/diff/1/cc/resources/resource_provid...
> cc/resources/resource_provider_unittest.cc:884: if (GetParam() !=
> ResourceProvider::GLTexture)
> Add a comment explaining why please
> 
>
https://codereview.chromium.org/444823002/diff/1/cc/resources/resource_provid...
> cc/resources/resource_provider_unittest.cc:887: unsigned sync_point = 0;
> nit: can you uint32 for this? someone previously went to the trouble to make
> those consistent for sync points as uint32s
> 
>
https://codereview.chromium.org/444823002/diff/1/cc/resources/resource_provid...
> cc/resources/resource_provider_unittest.cc:889:
> TextureMailbox(gpu::Mailbox::Generate(), GL_TEXTURE_2D, sync_point);
> nit: drop the "= TextureMailbox"

Done and done, thank you.

+benrb for cc_message.h since it's IPC related
+piman for content/ owners

[danakj, 2014-08-06 15:54:39]

> +benrb for cc_message.h since it's IPC related
> +piman for content/ owners

You just need the IPC review and you'll have enough owners fwiw.

[piman, 2014-08-06 17:13:24]

lgtm

[nasko, 2014-08-06 21:28:10]

IPC LGTM

[alexst (slow to review), 2014-08-06 21:29:12]

The CQ bit was checked by alexst@chromium.org

[commit-bot: I haz the power, 2014-08-06 21:34:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alexst@chromium.org/444823002/20001

[commit-bot: I haz the power, 2014-08-07 02:39:55]

Change committed as 287939