chrome/test/data/extensions/platform_apps/web_view/newwindow/embedder.js - Issue 444813002: Remove BrowserPlugin's -internal-attach method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/platform_apps/web_view/newwindow/embedder.js

Issue 444813002: Remove BrowserPlugin's -internal-attach method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move AttachToBrowserPlugin to RenderFrame Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/resources/extensions/web_view.js ('K') | « chrome/renderer/resources/extensions/web_view_experimental.js ('k') | content/browser/browser_plugin/browser_plugin_embedder.h » ('j') | content/renderer/browser_plugin/browser_plugin.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/platform_apps/web_view/newwindow/embedder.js

diff --git a/chrome/test/data/extensions/platform_apps/web_view/newwindow/embedder.js b/chrome/test/data/extensions/platform_apps/web_view/newwindow/embedder.js

index 934827619939b0d48724d1d6cdda2c4062a0a228..9585812aba73a27a32b0aff0ef0a8e48e8c266a4 100644

--- a/chrome/test/data/extensions/platform_apps/web_view/newwindow/embedder.js

+++ b/chrome/test/data/extensions/platform_apps/web_view/newwindow/embedder.js

@@ -435,9 +435,13 @@ function testNewWindowWebRequestRemoveElement() {

newwebview.request.onBeforeRequest.addListener(function(e) {

if (!calledWebRequestEvent) {

calledWebRequestEvent = true;

+ window.console.log('removing newwebview');

newwebview.parentElement.removeChild(newwebview);

+ window.console.log('after removeChild');

setTimeout(function() {

+ window.console.log('navigating webview');

webview.src = embedder.guestURL;

+ window.console.log('after navigating webview');

}, 0);

}

}, {urls: ['<all_urls>']});