Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: content/renderer/browser_plugin/mock_browser_plugin_manager.cc

Issue 444813002: Remove BrowserPlugin's -internal-attach method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't crash on tear down Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/mock_browser_plugin_manager.cc
diff --git a/content/renderer/browser_plugin/mock_browser_plugin_manager.cc b/content/renderer/browser_plugin/mock_browser_plugin_manager.cc
index 36d78b8675bf471e41f382c63b1afaa4026ebbd0..6870d0522f63a978d8adebe2bcc12a6a8dd13093 100644
--- a/content/renderer/browser_plugin/mock_browser_plugin_manager.cc
+++ b/content/renderer/browser_plugin/mock_browser_plugin_manager.cc
@@ -14,7 +14,6 @@ namespace content {
MockBrowserPluginManager::MockBrowserPluginManager(
RenderViewImpl* render_view)
: BrowserPluginManager(render_view),
- guest_instance_id_counter_(0),
last_plugin_(NULL) {
}
@@ -29,18 +28,6 @@ BrowserPlugin* MockBrowserPluginManager::CreateBrowserPlugin(
return last_plugin_;
}
-void MockBrowserPluginManager::AllocateInstanceID(
- BrowserPlugin* browser_plugin) {
- AllocateInstanceIDACK(browser_plugin, ++guest_instance_id_counter_);
-}
-
-void MockBrowserPluginManager::AllocateInstanceIDACK(
- BrowserPlugin* browser_plugin,
- int guest_instance_id) {
- scoped_ptr<base::DictionaryValue> extra_params(new base::DictionaryValue());
- browser_plugin->Attach(guest_instance_id, extra_params.Pass());
-}
-
bool MockBrowserPluginManager::Send(IPC::Message* msg) {
// This is a copy-and-paste from MockRenderThread::Send.
// We need to simulate a synchronous channel, thus we are going to receive
« no previous file with comments | « content/renderer/browser_plugin/mock_browser_plugin_manager.h ('k') | content/renderer/child_frame_compositing_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698