content/public/browser/browser_plugin_guest_manager.h - Issue 444813002: Remove BrowserPlugin's -internal-attach method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/browser_plugin_guest_manager.h

Issue 444813002: Remove BrowserPlugin's -internal-attach method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't crash on tear down Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/browser/browser_plugin_guest_manager.h

diff --git a/content/public/browser/browser_plugin_guest_manager.h b/content/public/browser/browser_plugin_guest_manager.h

index 9839dfb91c1aa8c182853a728f954d5e51ec8829..f56cd2abfef86c4e809f4dcc9ba55146de23a130 100644

--- a/content/public/browser/browser_plugin_guest_manager.h

+++ b/content/public/browser/browser_plugin_guest_manager.h

@@ -35,8 +35,8 @@ class CONTENT_EXPORT BrowserPluginGuestManager {

// not own the requested guest, then the embedder will be killed,

// and the |callback| will not be called.

virtual void MaybeGetGuestByInstanceIDOrKill(

- int guest_instance_id,

- int embedder_render_process_id,

+ WebContents* embedder_web_contents,

+ int browser_plugin_instance_id,

const GuestByInstanceIDCallback& callback) {}

// Iterates over all WebContents belonging to a given |embedder_web_contents|,