Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1601)

Unified Diff: content/public/browser/browser_plugin_guest_delegate.h

Issue 444813002: Remove BrowserPlugin's -internal-attach method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't crash on tear down Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/browser_plugin_guest_delegate.h
diff --git a/content/public/browser/browser_plugin_guest_delegate.h b/content/public/browser/browser_plugin_guest_delegate.h
index 2818982bef637d3c0507dc2b96d793e3a14c32a5..22a346b08de7caa2c664bd4aa6f8444ce2a3c28b 100644
--- a/content/public/browser/browser_plugin_guest_delegate.h
+++ b/content/public/browser/browser_plugin_guest_delegate.h
@@ -28,8 +28,7 @@ class CONTENT_EXPORT BrowserPluginGuestDelegate {
// Notification that the embedder will begin attachment. This is called
// prior to resuming resource loads.
- virtual void WillAttach(content::WebContents* embedder_web_contents,
- const base::DictionaryValue& extra_params) {}
+ virtual void WillAttach(content::WebContents* embedder_web_contents) {}
virtual WebContents* CreateNewGuestWindow(
const WebContents::CreateParams& create_params);
@@ -37,9 +36,6 @@ class CONTENT_EXPORT BrowserPluginGuestDelegate {
// Notification that the embedder has completed attachment.
virtual void DidAttach() {}
- // Requests the instance ID associated with the delegate.
- virtual int GetGuestInstanceID() const;
-
// Notification that the BrowserPlugin has resized.
virtual void ElementSizeChanged(const gfx::Size& old_size,
const gfx::Size& new_size) {}
« no previous file with comments | « content/common/browser_plugin/browser_plugin_messages.h ('k') | content/public/browser/browser_plugin_guest_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698