content/browser/web_contents/web_contents_impl.cc - Issue 444813002: Remove BrowserPlugin's -internal-attach method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 444813002: Remove BrowserPlugin's -internal-attach method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't crash on tear down Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 350f586d8dcd797d337b9559cf1ffad54f483f21..51b9177457e1af899003fd4dcc2cf9f4a6a6d154 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -464,9 +464,7 @@ WebContentsImpl* WebContentsImpl::CreateWithOpener(

if (params.guest_delegate) {

// This makes |new_contents| act as a guest.

// For more info, see comment above class BrowserPluginGuest.

- BrowserPluginGuest::Create(params.guest_delegate->GetGuestInstanceID(),

- new_contents,

- params.guest_delegate);

+ BrowserPluginGuest::Create(new_contents, params.guest_delegate);

// We are instantiating a WebContents for browser plugin. Set its subframe

// bit to true.

new_contents->is_subframe_ = true;