chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc - Issue 444813002: Remove BrowserPlugin's -internal-attach method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc

Issue 444813002: Remove BrowserPlugin's -internal-attach method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't crash on tear down Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/web_view_interactive_browsertest.cc ('k') | chrome/browser/guest_view/extension_options/extension_options_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc

diff --git a/chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc b/chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc

index caaadbb798610b4a457a2be7d6004529b91645ac..0bd2e417e4bd54b28c9a68c5c6328de876e885c3 100644

--- a/chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc

+++ b/chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc

@@ -60,7 +60,7 @@ void GuestViewInternalCreateGuestFunction::CreateGuestCallback(

int guest_instance_id = 0;

if (guest_web_contents) {

GuestViewBase* guest = GuestViewBase::FromWebContents(guest_web_contents);

- guest_instance_id = guest->GetGuestInstanceID();

+ guest_instance_id = guest->guest_instance_id();

}

SetResult(new base::FundamentalValue(guest_instance_id));

SendResponse(true);