content/public/browser/browser_plugin_guest_delegate.h - Issue 444813002: Remove BrowserPlugin's -internal-attach method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/browser_plugin_guest_delegate.h

Issue 444813002: Remove BrowserPlugin's -internal-attach method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated comment Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/browser/browser_plugin_guest_delegate.h

diff --git a/content/public/browser/browser_plugin_guest_delegate.h b/content/public/browser/browser_plugin_guest_delegate.h

index 2818982bef637d3c0507dc2b96d793e3a14c32a5..ac73bc4f3f9108c1d37f60acd6447327a93950ab 100644

--- a/content/public/browser/browser_plugin_guest_delegate.h

+++ b/content/public/browser/browser_plugin_guest_delegate.h

@@ -28,8 +28,7 @@ class CONTENT_EXPORT BrowserPluginGuestDelegate {

// Notification that the embedder will begin attachment. This is called

// prior to resuming resource loads.

- virtual void WillAttach(content::WebContents* embedder_web_contents,

- const base::DictionaryValue& extra_params) {}

+ virtual void WillAttach(content::WebContents* embedder_web_contents) {}

virtual WebContents* CreateNewGuestWindow(

const WebContents::CreateParams& create_params);