Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 444813002: Remove BrowserPlugin's -internal-attach method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_guest.h
diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h
index 2a1c78d6a826a37688c82ef51b15be498d5f78af..d23648c22f5eec0dd0d9a3f02f0484e09559f082 100644
--- a/content/browser/browser_plugin/browser_plugin_guest.h
+++ b/content/browser/browser_plugin/browser_plugin_guest.h
@@ -119,7 +119,8 @@ class CONTENT_EXPORT BrowserPluginGuest : public WebContentsObserver {
// Returns the identifier that uniquely identifies a browser plugin guest
// within an embedder.
- int instance_id() const { return instance_id_; }
+ // TODO(lazyboy): Rename this to guest_instance_id().
+ int instance_id() const { return guest_instance_id_; }
bool OnMessageReceivedFromEmbedder(const IPC::Message& message);
@@ -169,12 +170,10 @@ class CONTENT_EXPORT BrowserPluginGuest : public WebContentsObserver {
// Attaches this BrowserPluginGuest to the provided |embedder_web_contents|
// and initializes the guest with the provided |params|. Attaching a guest
// to an embedder implies that this guest's lifetime is no longer managed
- // by its opener, and it can begin loading resources. |extra_params| are
- // parameters passed into BrowserPlugin from JavaScript to be forwarded to
- // the content embedder.
- void Attach(WebContentsImpl* embedder_web_contents,
- const BrowserPluginHostMsg_Attach_Params& params,
- const base::DictionaryValue& extra_params);
+ // by its opener, and it can begin loading resources.
+ void Attach(int browser_plugin_instance_id,
+ WebContentsImpl* embedder_web_contents,
+ const BrowserPluginHostMsg_Attach_Params& params);
// Returns whether BrowserPluginGuest is interested in receiving the given
// |message|.
@@ -205,9 +204,9 @@ class CONTENT_EXPORT BrowserPluginGuest : public WebContentsObserver {
void WillDestroy();
- void Initialize(const BrowserPluginHostMsg_Attach_Params& params,
- WebContentsImpl* embedder_web_contents,
- const base::DictionaryValue& extra_params);
+ void Initialize(int browser_plugin_instance_id,
+ const BrowserPluginHostMsg_Attach_Params& params,
+ WebContentsImpl* embedder_web_contents);
bool InAutoSizeBounds(const gfx::Size& size) const;
@@ -327,7 +326,7 @@ class CONTENT_EXPORT BrowserPluginGuest : public WebContentsObserver {
// An identifier that uniquely identifies a browser plugin guest within an
// embedder.
- const int instance_id_;
+ const int guest_instance_id_;
float guest_device_scale_factor_;
gfx::Rect guest_window_rect_;
gfx::Rect guest_screen_rect_;

Powered by Google App Engine
This is Rietveld 408576698