Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1829)

Unified Diff: chrome/renderer/extensions/guest_view_internal_custom_bindings.h

Issue 444813002: Remove BrowserPlugin's -internal-attach method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/guest_view_internal_custom_bindings.h
diff --git a/chrome/renderer/extensions/guest_view_internal_custom_bindings.h b/chrome/renderer/extensions/guest_view_internal_custom_bindings.h
new file mode 100644
index 0000000000000000000000000000000000000000..66ffb1f254ac801530975d775b8779f48b6113a7
--- /dev/null
+++ b/chrome/renderer/extensions/guest_view_internal_custom_bindings.h
@@ -0,0 +1,34 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_RENDERER_EXTENSIONS_GUEST_VIEW_INTERNAL_CUSTOM_BINDINGS_H_
+#define CHROME_RENDERER_EXTENSIONS_GUEST_VIEW_INTERNAL_CUSTOM_BINDINGS_H_
+
+#include "extensions/renderer/object_backed_native_handler.h"
+
+namespace extensions {
+class Dispatcher;
+
+// Implements custom bindings for the guestViewInternal API.
+class GuestViewInternalCustomBindings : public ObjectBackedNativeHandler {
+ public:
+ explicit GuestViewInternalCustomBindings(ScriptContext* context);
+
+ private:
+ // AttachGuest attaches a GuestView to a provided container element. Once
+ // attached, the GuestView will participate in layout of the container page
+ // and become visible on screen.
+ // AttachGuest takes three parameters: an |element_instance_id|, a
+ // |guest_instance_id| and an |attach_params| dictionary. The first
+ // parameter, |element_instance_id|, uniquely identifies a container within
+ // the content module that is able to host GuestViews. The second parameter,
+ // |guest_instance_id|, uniquely identifies a GuestView. The third parameter
+ // is typically used to convey the current state of the container element
+ // at the time of attachment.
not at google - send to devlin 2014/08/14 19:51:22 Could you phrase these arguments as a list, rather
Fady Samuel 2014/08/14 20:02:56 Done.
+ void AttachGuest(const v8::FunctionCallbackInfo<v8::Value>& args);
+};
+
+} // namespace extensions
+
+#endif // CHROME_RENDERER_EXTENSIONS_GUEST_VIEW_INTERNAL_CUSTOM_BINDINGS_H_

Powered by Google App Engine
This is Rietveld 408576698