Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1603)

Unified Diff: chrome/browser/guest_view/web_view/web_view_guest.cc

Issue 444813002: Remove BrowserPlugin's -internal-attach method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/web_view/web_view_guest.cc
diff --git a/chrome/browser/guest_view/web_view/web_view_guest.cc b/chrome/browser/guest_view/web_view/web_view_guest.cc
index 88ff3ddf68abd3f61e9924c69d4e2d4694192a88..306e9c6b82202ce9dbf38a19e4aefcd79bea4389 100644
--- a/chrome/browser/guest_view/web_view/web_view_guest.cc
+++ b/chrome/browser/guest_view/web_view/web_view_guest.cc
@@ -298,7 +298,7 @@ void WebViewGuest::CreateWebContents(
void WebViewGuest::DidAttachToEmbedder() {
std::string name;
- if (extra_params()->GetString(webview::kName, &name)) {
+ if (attach_params()->GetString(webview::kName, &name)) {
// If the guest window's name is empty, then the WebView tag's name is
// assigned. Otherwise, the guest window's name takes precedence over the
// WebView tag's name.
@@ -308,15 +308,15 @@ void WebViewGuest::DidAttachToEmbedder() {
ReportFrameNameChange(name_);
std::string user_agent_override;
- if (extra_params()->GetString(webview::kParameterUserAgentOverride,
- &user_agent_override)) {
+ if (attach_params()->GetString(webview::kParameterUserAgentOverride,
+ &user_agent_override)) {
SetUserAgentOverride(user_agent_override);
} else {
SetUserAgentOverride("");
}
std::string src;
- if (extra_params()->GetString("src", &src) && !src.empty())
+ if (attach_params()->GetString("src", &src) && !src.empty())
NavigateGuest(src);
if (GetOpener()) {
« no previous file with comments | « chrome/browser/guest_view/guest_view_manager.cc ('k') | chrome/browser/renderer_host/chrome_extension_message_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698