Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 444803002: Removed -webkit-marquee-increment leftovers. (Closed)

Created:
6 years, 4 months ago by rune
Modified:
6 years, 4 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Project:
blink
Visibility:
Public.

Description

Removed -webkit-marquee-increment leftovers. Only html attribute lengths are now supported remove recognition of keywords from the CSS property. Gets rid of the custom style builder function by using generated length conversion method instead. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179698

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -31 lines) Patch
M Source/core/css/CSSProperties.in View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
rune
6 years, 4 months ago (2014-08-06 09:50:54 UTC) #1
Julien - ping for review
YAY! LGTM!
6 years, 4 months ago (2014-08-06 17:58:35 UTC) #2
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 4 months ago (2014-08-06 17:58:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/444803002/1
6 years, 4 months ago (2014-08-06 17:59:46 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-06 18:08:49 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 18:10:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/15229) mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/18685) mac_gpu ...
6 years, 4 months ago (2014-08-06 18:10:11 UTC) #7
rune
The CQ bit was checked by rune@opera.com
6 years, 4 months ago (2014-08-07 07:52:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/444803002/20001
6 years, 4 months ago (2014-08-07 07:53:37 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 09:28:59 UTC) #10
Message was sent while issue was closed.
Change committed as 179698

Powered by Google App Engine
This is Rietveld 408576698