Issue 444793003: [style] Replace various "X() != 1" checks with "!X()".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 444793003: [style] Replace various "X() != 1" checks with "!X()". (Closed)

Created:
6 years, 4 months ago by eroman

Modified:
6 years, 4 months ago

Reviewers:
agl

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

[style] Replace various "X() != 1" checks with "!X()". For functions in BoringSSL where X() is guaranteed to return either 1 or 0. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287714

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -16 lines)			Patch
M	content/child/webcrypto/openssl/rsa_key_openssl.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/child/webcrypto/openssl/rsa_oaep_openssl.cc	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	content/child/webcrypto/openssl/rsa_ssa_openssl.cc	View	2 chunks	+4 lines, -6 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/444793003/1

6 years, 4 months ago (2014-08-06 00:31:35 UTC) #4

Message was sent while issue was closed.

Change committed as 287714