runtime/vm/parser.cc - Issue 444793002: Report compile time error if const class has non-const initializer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/parser.cc

Issue 444793002: Report compile time error if const class has non-const initializer (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/parser.cc

===================================================================

--- runtime/vm/parser.cc (revision 38902)

+++ runtime/vm/parser.cc (working copy)

@@ -2379,7 +2379,9 @@

ASSERT(IsIdentifier());

ConsumeToken();

ExpectToken(Token::kASSIGN);

- if (field.is_const()) {

+ if (current_class().is_const()) {

+ // If the class has a const contructor, the initializer

+ // expression must be a compile-time constant.

init_expr = ParseConstExpr();

} else {

intptr_t expr_pos = TokenPos();

« no previous file with comments | « no previous file | tests/language/language.status » ('j') | no next file with comments »