Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 44473002: Devirtualize destructors for several mediastream platform classes (Closed)

Created:
7 years, 1 month ago by Inactive
Modified:
7 years, 1 month ago
CC:
blink-reviews, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Devirtualize destructors for several mediastream platform classes Devirtualize destructors for several mediastream platform classes to avoid creating unnecessary vtables. Those classes are never subclasses, nor do they have any virtual function. BUG=311561 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160597

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M Source/core/platform/mediastream/MediaStreamDescriptor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/mediastream/RTCConfiguration.h View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
7 years, 1 month ago (2013-10-25 14:55:31 UTC) #1
abarth-chromium
lgtm
7 years, 1 month ago (2013-10-25 16:10:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/44473002/1
7 years, 1 month ago (2013-10-25 16:10:19 UTC) #3
commit-bot: I haz the power
Change committed as 160597
7 years, 1 month ago (2013-10-25 17:05:55 UTC) #4
Tommy Widenflycht
7 years, 1 month ago (2013-10-28 08:36:31 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698