Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 444723003: Revert of Modify data_reduction_proxy_header to support tamper detection logic. (Closed)

Created:
6 years, 4 months ago by robliao
Modified:
6 years, 4 months ago
Reviewers:
bengr, Yaron, xingx, xingx1, tonyg, bolian
Base URL:
https://chromium.googlesource.com/chromium/src.git@work
Project:
chromium
Visibility:
Public.

Description

Revert of Modify data_reduction_proxy_header to support tamper detection logic. (https://codereview.chromium.org/387353003/) Reason for revert: Causes DataReductionProxyHeadersTest.GetDataReductionProxyHeaderWithFingerprintRemoved to timeout on the bots. TBR=bengr1@chromium.org, tonyg@chromium.org, bolian@chromium.org, yfriedman@chromium.org NOTREECHECKS=true NOTRY=true BUG=381907 Original issue's description: > 1. Adds action-parsing functionality for data reduction proxy header. > > 2. Adds a couple of functions to return different fingerprint value for tamper detection. > > 3. Adds a function to remove Chrome-Proxy header's fingerprint from its header values, and return the rest of header values. > > 4. Changes HasDataReductionProxyViaHeader to also tell > whether data reduction proxy Via header occurs at the last > or not. > > > BUG=381907 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287561 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287608

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -549 lines) Patch
M chrome/browser/android/intercept_download_resource_throttle.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/page_load_histograms.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/common/data_reduction_proxy_headers.h View 2 chunks +2 lines, -39 lines 0 comments Download
M components/data_reduction_proxy/common/data_reduction_proxy_headers.cc View 7 chunks +12 lines, -118 lines 0 comments Download
M components/data_reduction_proxy/common/data_reduction_proxy_headers_unittest.cc View 4 chunks +8 lines, -388 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
robliao
Created Revert of Modify data_reduction_proxy_header to support tamper detection logic.
6 years, 4 months ago (2014-08-05 21:49:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robliao@chromium.org/444723003/1
6 years, 4 months ago (2014-08-05 21:51:56 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 21:51:57 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-05 21:51:57 UTC) #4
Yaron
On 2014/08/05 21:51:57, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 4 months ago (2014-08-05 21:54:12 UTC) #5
robliao
On 2014/08/05 21:54:12, Yaron wrote: > On 2014/08/05 21:51:57, I haz the power (commit-bot) wrote: ...
6 years, 4 months ago (2014-08-05 21:54:43 UTC) #6
robliao
The CQ bit was checked by robliao@chromium.org
6 years, 4 months ago (2014-08-05 21:58:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robliao@chromium.org/444723003/1
6 years, 4 months ago (2014-08-05 22:00:39 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 22:03:10 UTC) #9
Message was sent while issue was closed.
Change committed as 287608

Powered by Google App Engine
This is Rietveld 408576698