Issue 444633003: Revert of [DevTools] Move DispatchOnDevToolsFrontend to embedder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 444633003: Revert of [DevTools] Move DispatchOnDevToolsFrontend to embedder. (Closed)

Created:
6 years, 4 months ago by kouhei (in TOK)

Modified:
6 years, 4 months ago

Reviewers:
jam, dgozman, pfeldman

CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of [DevTools] Move DispatchOnDevToolsFrontend to embedder. (https://codereview.chromium.org/418243003/) Reason for revert: I think this CL broke inspector/ layout tests: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/35062 Original issue's description: > [DevTools] Move DispatchOnDevToolsFrontend to embedder. > > We already have a way to send message via ExecuteJavaScript, > no need for another mechanism. > > BUG=398046 > TBR=jam > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287514 TBR=pfeldman@chromium.org,jam@chromium.org,dgozman@chromium.org NOTREECHECKS=true NOTRY=true BUG=398046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287558

Patch Set 1 #

Created: 6 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -9 lines)			Patch
M	chrome/browser/devtools/devtools_ui_bindings.cc	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	content/browser/devtools/devtools_frontend_host_impl.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/browser/devtools/devtools_frontend_host_impl.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	content/public/browser/devtools_frontend_host.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/renderer/devtools/devtools_client.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/renderer/devtools/devtools_client.cc	View	2 chunks	+18 lines, -0 lines	0 comments	Download
M	content/shell/browser/shell_devtools_frontend.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kouhei (in TOK)

Created Revert of [DevTools] Move DispatchOnDevToolsFrontend to embedder.

6 years, 4 months ago (2014-08-05 17:40:16 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/444633003/1

6 years, 4 months ago (2014-08-05 17:41:46 UTC) #2

Message was sent while issue was closed.

Change committed as 287558

Expand Messages | Collapse Messages