chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc - Issue 444603003: Hook up the Mac password bubble to the browser and add browser tests.

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

Issue 444603003: Hook up the Mac password bubble to the browser and add browser tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sort gypi Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_browsertest.mm ('K') | « chrome/browser/ui/passwords/manage_passwords_test.cc ('k') | chrome/browser/ui/views/passwords/manage_passwords_icon_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

index 9342aa3eec911b7f7130ea78b47e23388202f925..3d12ec9b43649f07d1b5878650fbf159431c69d7 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

@@ -6,8 +6,12 @@

#include "base/metrics/histogram_samples.h"

#include "chrome/browser/ui/browser.h"

+#include "chrome/browser/ui/passwords/manage_passwords_test.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

-#include "chrome/browser/ui/views/passwords/manage_passwords_view_test.h"

+#include "chrome/browser/ui/views/frame/browser_view.h"

+#include "chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h"

+#include "chrome/browser/ui/views/passwords/manage_passwords_icon_view.h"

+#include "chrome/browser/ui/views/toolbar/toolbar_view.h"

#include "components/password_manager/core/browser/password_manager_metrics_util.h"

#include "components/password_manager/core/browser/stub_password_manager_client.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -18,9 +22,17 @@ const char kDisplayDispositionMetric[] = "PasswordBubble.DisplayDisposition";

} // namespace

-typedef ManagePasswordsViewTest ManagePasswordsBubbleViewTest;

namespace metrics_util = password_manager::metrics_util;

+class ManagePasswordsBubbleViewTest : public ManagePasswordsTest {

+ virtual ManagePasswordsIcon* view() OVERRIDE {

sky 2014/08/05 17:03:30 public: along with a private: DISALLOW...

dconnelly 2014/08/06 12:46:12 Done.

+ BrowserView* browser_view = static_cast<BrowserView*>(browser()->window());

+ return browser_view->GetToolbarView()

sky 2014/08/05 17:03:30 Did the formatter do this? If not, I would put loc

dconnelly 2014/08/06 12:46:12 It did.

+ ->location_bar()

+ ->manage_passwords_icon_view();

+ }

+};

IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest, BasicOpenAndClose) {

EXPECT_FALSE(ManagePasswordsBubbleView::IsShowing());

ManagePasswordsBubbleView::ShowBubble(