Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

Issue 444603003: Hook up the Mac password bubble to the browser and add browser tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix views build Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
index a2f6d3d7852427d9a44317e9a4e8d8ce2d381cc1..d4a4967a7275cec59d6cdcbecfce9d5835cfd646 100644
--- a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
+++ b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
@@ -133,7 +133,7 @@ LocationBarViewMac::LocationBarViewMac(AutocompleteTextField* field,
new GeneratedCreditCardDecoration(this)),
search_button_decoration_(new SearchButtonDecoration(this)),
manage_passwords_decoration_(
- new ManagePasswordsDecoration(command_updater)),
+ new ManagePasswordsDecoration(command_updater, this)),
browser_(browser),
weak_ptr_factory_(this) {
for (size_t i = 0; i < CONTENT_SETTINGS_NUM_TYPES; ++i) {
@@ -222,6 +222,7 @@ void LocationBarViewMac::UpdateManagePasswordsIconAndBubble() {
return;
ManagePasswordsUIController::FromWebContents(web_contents)
->UpdateIconAndBubbleState(manage_passwords_decoration_->icon());
+ OnDecorationsChanged();
}
void LocationBarViewMac::UpdatePageActions() {
@@ -526,6 +527,7 @@ NSPoint LocationBarViewMac::GetPageActionBubblePoint(
}
void LocationBarViewMac::Update(const WebContents* contents) {
+ UpdateManagePasswordsIconAndBubble();
UpdateStarDecorationVisibility();
UpdateTranslateDecoration();
UpdateZoomDecoration();

Powered by Google App Engine
This is Rietveld 408576698