Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Side by Side Diff: chrome/browser/ui/browser_commands.cc

Issue 444603003: Hook up the Mac password bubble to the browser and add browser tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sort gypi Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser_commands.h" 5 #include "chrome/browser/ui/browser_commands.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "base/prefs/pref_service.h" 9 #include "base/prefs/pref_service.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 770 matching lines...) Expand 10 before | Expand all | Expand 10 after
781 if (chrome_translate_client->GetLanguageState().translation_pending()) 781 if (chrome_translate_client->GetLanguageState().translation_pending())
782 step = translate::TRANSLATE_STEP_TRANSLATING; 782 step = translate::TRANSLATE_STEP_TRANSLATING;
783 else if (chrome_translate_client->GetLanguageState().IsPageTranslated()) 783 else if (chrome_translate_client->GetLanguageState().IsPageTranslated())
784 step = translate::TRANSLATE_STEP_AFTER_TRANSLATE; 784 step = translate::TRANSLATE_STEP_AFTER_TRANSLATE;
785 } 785 }
786 browser->window()->ShowTranslateBubble( 786 browser->window()->ShowTranslateBubble(
787 web_contents, step, translate::TranslateErrors::NONE, true); 787 web_contents, step, translate::TranslateErrors::NONE, true);
788 } 788 }
789 789
790 void ManagePasswordsForPage(Browser* browser) { 790 void ManagePasswordsForPage(Browser* browser) {
791 // TODO(mkwst): Implement this feature on Mac: http://crbug.com/261628
792 #if !defined(OS_MACOSX)
793 if (!browser->window()->IsActive()) 791 if (!browser->window()->IsActive())
794 return; 792 return;
795 793
796 WebContents* web_contents = 794 WebContents* web_contents =
797 browser->tab_strip_model()->GetActiveWebContents(); 795 browser->tab_strip_model()->GetActiveWebContents();
798 chrome::ShowManagePasswordsBubble(web_contents); 796 chrome::ShowManagePasswordsBubble(web_contents);
799 #endif
800 } 797 }
801 798
802 void TogglePagePinnedToStartScreen(Browser* browser) { 799 void TogglePagePinnedToStartScreen(Browser* browser) {
803 #if defined(OS_WIN) 800 #if defined(OS_WIN)
804 MetroPinTabHelper::FromWebContents( 801 MetroPinTabHelper::FromWebContents(
805 browser->tab_strip_model()->GetActiveWebContents())-> 802 browser->tab_strip_model()->GetActiveWebContents())->
806 TogglePinnedToStartScreen(); 803 TogglePinnedToStartScreen();
807 #endif 804 #endif
808 } 805 }
809 806
(...skipping 476 matching lines...) Expand 10 before | Expand all | Expand 10 after
1286 browser->profile(), 1283 browser->profile(),
1287 browser->host_desktop_type())); 1284 browser->host_desktop_type()));
1288 app_browser->tab_strip_model()->AppendWebContents(contents, true); 1285 app_browser->tab_strip_model()->AppendWebContents(contents, true);
1289 1286
1290 contents->GetMutableRendererPrefs()->can_accept_load_drops = false; 1287 contents->GetMutableRendererPrefs()->can_accept_load_drops = false;
1291 contents->GetRenderViewHost()->SyncRendererPrefs(); 1288 contents->GetRenderViewHost()->SyncRendererPrefs();
1292 app_browser->window()->Show(); 1289 app_browser->window()->Show();
1293 } 1290 }
1294 1291
1295 } // namespace chrome 1292 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698