Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_browsertest.mm

Issue 444603003: Hook up the Mac password bubble to the browser and add browser tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix views build Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/mac/foundation_util.h"
6 #include "base/mac/scoped_objc_class_swizzler.h"
7 #include "chrome/browser/ui/browser.h"
8 #include "chrome/browser/ui/browser_window.h"
9 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
10 #import "chrome/browser/ui/cocoa/info_bubble_window.h"
11 #include "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
12 #include "chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.h"
13 #include "chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.h"
14 #include "chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_controller.h "
15 #include "chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view _controller.h"
16 #include "chrome/browser/ui/passwords/manage_passwords_test.h"
17 #include "chrome/browser/ui/tabs/tab_strip_model.h"
18 #include "content/public/test/test_utils.h"
19 #include "testing/gtest_mac.h"
20
21 // A helper class to swizzle [NSWindow isKeyWindow] to always return true.
22 @interface AlwaysKeyNSWindow : NSWindow
23 - (BOOL)isKeyWindow;
24 @end
25
26 @implementation AlwaysKeyNSWindow
27 - (BOOL)isKeyWindow {
28 return YES;
29 }
30 @end
31
32 // Integration tests for the Mac password bubble.
33 class ManagePasswordsBubbleTest : public ManagePasswordsTest {
34 public:
35 virtual void SetUpOnMainThread() OVERRIDE {
36 ManagePasswordsTest::SetUpOnMainThread();
37 browser()->window()->Show();
38 }
39
40 virtual void TearDownOnMainThread() OVERRIDE {
41 ManagePasswordsTest::TearDownOnMainThread();
42 }
43
44 ManagePasswordsBubbleController* controller() {
45 return ManagePasswordsBubbleCocoa::instance()
46 ? ManagePasswordsBubbleCocoa::instance()->controller_
47 : nil;
48 }
49
50 void DoWithSwizzledNSWindow(void (^block)(void)) {
51 // Swizzle [NSWindow isKeyWindow] so that BrowserWindow::IsActive will
52 // return true and the bubble can be displayed.
53 base::mac::ScopedObjCClassSwizzler swizzler(
54 [NSWindow class], [AlwaysKeyNSWindow class], @selector(isKeyWindow));
55 block();
56 }
57
58 void DisableAnimationsOnController() {
59 InfoBubbleWindow* window =
60 base::mac::ObjCCast<InfoBubbleWindow>([controller() window]);
61 [window setAllowedAnimations:info_bubble::kAnimateNone];
62 }
63
64 ManagePasswordsDecoration* decoration() {
65 NSWindow* window = browser()->window()->GetNativeWindow();
66 BrowserWindowController* bwc =
67 [BrowserWindowController browserWindowControllerForWindow:window];
68 return [bwc locationBarBridge]->manage_passwords_decoration();
69 }
70
71 virtual ManagePasswordsIcon* view() OVERRIDE {
72 return decoration()->icon();
73 }
74 };
75
76 IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleTest,
77 PasswordEntryShowsPendingSaveView) {
78 EXPECT_FALSE(ManagePasswordsBubbleCocoa::instance());
79 DoWithSwizzledNSWindow(^{ SetupPendingPassword(); });
80 EXPECT_TRUE(ManagePasswordsBubbleCocoa::instance());
81 EXPECT_EQ([ManagePasswordsBubblePendingViewController class],
82 [controller().currentController class]);
83 EXPECT_TRUE(view()->active());
84 }
85
86 IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleTest, IconClickTogglesBubble) {
87 // Show the bubble automatically.
88 DoWithSwizzledNSWindow(^{ SetupPendingPassword(); });
89
90 // Close the bubble by clicking on the decoration.
91 DisableAnimationsOnController();
92 decoration()->OnMousePressed(NSZeroRect, NSZeroPoint);
93 EXPECT_FALSE(ManagePasswordsBubbleCocoa::instance());
94
95 // Show the bubble by clicking on the decoration.
96 DoWithSwizzledNSWindow(^{
97 decoration()->OnMousePressed(NSZeroRect, NSZeroPoint);
98 });
99 EXPECT_TRUE(ManagePasswordsBubbleCocoa::instance());
100 }
101
102 IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleTest, TabChangeTogglesIcon) {
103 // Show the bubble (and icon) automatically.
104 DoWithSwizzledNSWindow(^{ SetupPendingPassword(); });
105 EXPECT_TRUE(decoration()->IsVisible());
106
107 // Open a new tab.
108 int firstTab = browser()->tab_strip_model()->active_index();
109 AddTabAtIndex(
110 firstTab + 1, GURL("http://foo.bar/"), content::PAGE_TRANSITION_TYPED);
111 EXPECT_FALSE(decoration()->IsVisible());
112
113 // Switch back to the previous tab.
114 browser()->tab_strip_model()->ActivateTabAt(firstTab, true);
115 EXPECT_TRUE(decoration()->IsVisible());
116 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698