Issue 4446005: Chromoting: Rename ChromotocolConfig -> SessionConfig

Issue 4446005: Chromoting: Rename ChromotocolConfig -> SessionConfig (Closed)

Created:
10 years, 1 month ago by garykac

Modified:
9 years, 6 months ago

Reviewers:
Sergey Ulanov, awong

CC:
chromium-reviews, Alpha Left Google, dmac, awong, garykac, Paweł Hajdan Jr., ben+cc_chromium.org, Sergey Ulanov, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org

Base URL:
http://git.chromium.org/git/chromium.git

Visibility:
Public.

Description

Chromoting: Rename ChromotocolConfig -> SessionConfig BUG=none TEST=build chrome, chromoting Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65451

Patch Set 1 #

Patch Set 2 : Change to SessionConfig #

Total comments: 2

Patch Set 3 : Rename config.* to session_config.* #

Patch Set 4 : post sync/merge #

Patch Set 5 : Rename candidate_config vars #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+159 lines, -168 lines)			Patch
M	chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/extensions/docs/permission_warnings.html	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	remoting/host/chromoting_host.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/host/chromoting_host.cc	View	1 2	3 chunks	+11 lines, -12 lines	0 comments	Download
M	remoting/protocol/fake_session.h	View	1	3 chunks	+5 lines, -7 lines	0 comments	Download
M	remoting/protocol/fake_session.cc	View	1	4 chunks	+5 lines, -8 lines	0 comments	Download
M	remoting/protocol/jingle_connection_to_host.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	remoting/protocol/jingle_session.h	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
M	remoting/protocol/jingle_session.cc	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	remoting/protocol/jingle_session_manager.h	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
M	remoting/protocol/jingle_session_manager.cc	View	1 2 3 4	8 chunks	+10 lines, -12 lines	0 comments	Download
M	remoting/protocol/jingle_session_unittest.cc	View	1	5 chunks	+3 lines, -5 lines	0 comments	Download
M	remoting/protocol/protocol_test_client.cc	View	1	4 chunks	+2 lines, -4 lines	0 comments	Download
M	remoting/protocol/session.h	View	1 2	4 chunks	+4 lines, -6 lines	0 comments	Download
A +	remoting/protocol/session_config.h	View		7 chunks	+29 lines, -26 lines	0 comments	Download
A +	remoting/protocol/session_config.cc	View		9 chunks	+42 lines, -40 lines	0 comments	Download
M	remoting/protocol/session_manager.h	View	1	4 chunks	+4 lines, -6 lines	0 comments	Download
M	remoting/protocol/video_reader.h	View	1	1 chunk	+5 lines, -7 lines	0 comments	Download
M	remoting/protocol/video_reader.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/protocol/video_writer.h	View	1	1 chunk	+5 lines, -7 lines	0 comments	Download
M	remoting/protocol/video_writer.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/remoting.gyp	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

10 years, 1 month ago (2010-11-05 02:07:35 UTC) #2

Thanks for making this happen! The only issue is that config.{h}cc} need to be
renamed, but looks good otherwise.

http://codereview.chromium.org/4446005/diff/3001/4005
File remoting/protocol/config.h (right):

http://codereview.chromium.org/4446005/diff/3001/4005#newcode62
remoting/protocol/config.h:62: class SessionConfig {
Can you please rename the file too?

http://codereview.chromium.org/4446005/diff/3001/4010
File remoting/protocol/jingle_session_manager.cc (right):

http://codereview.chromium.org/4446005/diff/3001/4010#newcode222
remoting/protocol/jingle_session_manager.cc:222: CandidateSessionConfig* config,
candidate_config for consistency

Expand Messages | Collapse Messages