Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 444593003: adb_gdb : Import tools/gdb/gdb_chrome.py as part of adb_gdb script (Closed)

Created:
6 years, 4 months ago by kishorags_
Modified:
6 years, 3 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, r.kasibhatla, RaviKasibhatla
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Import tools/gdb/gdb_chrome.py as part of adb_gdb script Presently, first time developer need to copy paste source for inserting gdb_chrome.py in ~/.gdbinit file. This change avoids the manual step & works seem less for first time developer also. BUG=None Committed: https://crrev.com/145425d17c8351595048b0dff319e8ff284d983f Cr-Commit-Position: refs/heads/master@{#291581}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M build/android/adb_gdb View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
kishorags_
PTAL. Thanks
6 years, 4 months ago (2014-08-05 12:29:10 UTC) #1
RaviKasibhatla
lgtm non-owner lgtm. :)
6 years, 4 months ago (2014-08-07 07:36:56 UTC) #2
kishorags_
The CQ bit was checked by kishor.ag@samsung.com
6 years, 4 months ago (2014-08-17 10:15:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kishor.ag@samsung.com/444593003/1
6 years, 4 months ago (2014-08-17 10:15:50 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-17 11:27:52 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-17 12:00:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/36396)
6 years, 4 months ago (2014-08-17 12:00:08 UTC) #7
kishorags_
The CQ bit was checked by kishor.ag@samsung.com
6 years, 4 months ago (2014-08-23 10:54:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kishor.ag@samsung.com/444593003/1
6 years, 4 months ago (2014-08-23 10:55:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (1) as ed81d04f55f389ebaa792e974e60ad32407734e0
6 years, 4 months ago (2014-08-23 21:27:31 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:30:56 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/145425d17c8351595048b0dff319e8ff284d983f
Cr-Commit-Position: refs/heads/master@{#291581}

Powered by Google App Engine
This is Rietveld 408576698