Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 444583006: SkThreadPool and co. are not public. (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

SkThreadPool and co. are not public. BUG=skia: Committed: https://skia.googlesource.com/skia/+/847092c88be671c06bdf24aa02b5a66e7a593a15

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -336 lines) Patch
M gyp/public_headers.gypi View 1 chunk +0 lines, -12 lines 0 comments Download
M gyp/utils.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
D include/utils/SkCondVar.h View 1 chunk +0 lines, -78 lines 0 comments Download
D include/utils/SkRunnable.h View 1 chunk +0 lines, -25 lines 0 comments Download
D include/utils/SkThreadPool.h View 1 chunk +0 lines, -221 lines 0 comments Download
A + src/utils/SkCondVar.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/utils/SkRunnable.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/utils/SkThreadPool.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein
6 years, 4 months ago (2014-08-05 13:02:49 UTC) #1
mtklein
On 2014/08/05 13:02:49, mtklein wrote: Ping Mike?
6 years, 4 months ago (2014-08-06 13:25:42 UTC) #2
reed1
lgtm
6 years, 4 months ago (2014-08-06 13:34:22 UTC) #3
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-06 13:43:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/444583006/1
6 years, 4 months ago (2014-08-06 13:44:07 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 13:55:18 UTC) #6
Message was sent while issue was closed.
Change committed as 847092c88be671c06bdf24aa02b5a66e7a593a15

Powered by Google App Engine
This is Rietveld 408576698