Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 444583002: MacViews: Get widget_interactive_uitest compiling on Mac (Closed)

Created:
6 years, 4 months ago by tapted
Modified:
6 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

MacViews: Get widget_interactive_uitest compiling on Mac This is done by refactoring some tests to observe focus changes in a cross-platform manner, and by converting some custom-crafted events to use the cross-platform event generator. For now, the code that is only enabled on Windows is unchanged. This still has aura dependencies, but I hope to enable some of these tests on Mac in future. BUG=399191 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287944

Patch Set 1 #

Patch Set 2 : Fix TouchSelectionQuickMenuIsNotActivated #

Total comments: 3

Patch Set 3 : Try FocusListener #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -303 lines) Patch
D ui/views/focus/focus_manager_test.h View 1 2 1 chunk +0 lines, -106 lines 0 comments Download
D ui/views/focus/focus_manager_test.cc View 1 2 1 chunk +0 lines, -143 lines 0 comments Download
M ui/views/focus/focus_manager_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/focus/focus_traversal_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + ui/views/test/focus_manager_test.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/views/test/focus_manager_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/views.gyp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 1 2 17 chunks +64 lines, -46 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tapted
Hi sky, please take a look. (this is split of from the "big picture" CL ...
6 years, 4 months ago (2014-08-05 13:42:26 UTC) #1
sky
https://codereview.chromium.org/444583002/diff/20001/ui/views/test/widget_test.h File ui/views/test/widget_test.h (right): https://codereview.chromium.org/444583002/diff/20001/ui/views/test/widget_test.h#newcode103 ui/views/test/widget_test.h:103: static gfx::NativeWindow CurrentlyFocussedWindow(Widget* widget_context); focused https://codereview.chromium.org/444583002/diff/20001/ui/views/test/widget_test.h#newcode103 ui/views/test/widget_test.h:103: static gfx::NativeWindow ...
6 years, 4 months ago (2014-08-05 17:15:52 UTC) #2
tapted
Hi sky, PTAL at patchset 3 for your consideration. It refactors the tests to use ...
6 years, 4 months ago (2014-08-06 06:37:28 UTC) #3
sky
LGTM
6 years, 4 months ago (2014-08-06 17:46:58 UTC) #4
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 4 months ago (2014-08-06 23:02:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/444583002/60001
6 years, 4 months ago (2014-08-06 23:04:59 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 02:50:15 UTC) #7
Message was sent while issue was closed.
Change committed as 287944

Powered by Google App Engine
This is Rietveld 408576698