chrome/browser/chrome_elf_init_win.h - Issue 444543002: Add export to query for blacklisted-ness.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/chrome_elf_init_win.h

Issue 444543002: Add export to query for blacklisted-ness. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Pre-review cleanup. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/chrome_elf_init_unittest_win.cc ('K') | « chrome/browser/chrome_elf_init_unittest_win.cc ('k') | chrome/browser/chrome_elf_init_win.cc » ('j') | chrome/browser/chrome_elf_init_win.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_CHROME_ELF_INIT_WIN_H_	5 #ifndef CHROME_BROWSER_CHROME_ELF_INIT_WIN_H_

6 #define CHROME_BROWSER_CHROME_ELF_INIT_WIN_H_	6 #define CHROME_BROWSER_CHROME_ELF_INIT_WIN_H_

7	7

	8 #include "base/strings/string16.h"

	9

8 // Field trial name and full name for the blacklist disabled group.	10 // Field trial name and full name for the blacklist disabled group.

9 extern const char kBrowserBlacklistTrialName[];	11 extern const char kBrowserBlacklistTrialName[];

10 extern const char kBrowserBlacklistTrialDisabledGroupName[];	12 extern const char kBrowserBlacklistTrialDisabledGroupName[];

11	13

12 // Prepare any initialization code for Chrome Elf's setup (This will generally	14 // Prepare any initialization code for Chrome Elf's setup (This will generally

13 // only affect future runs since Chrome Elf is already setup by this point).	15 // only affect future runs since Chrome Elf is already setup by this point).

14 void InitializeChromeElf();	16 void InitializeChromeElf();

15	17

16 // Add the blacklist from the finch configs in the registry.	18 // Add the blacklist from the finch configs in the registry.

17 void AddFinchBlacklistToRegistry();	19 void AddFinchBlacklistToRegistry();

18	20

19 // Set the required state for an enabled browser blacklist.	21 // Set the required state for an enabled browser blacklist.

20 void BrowserBlacklistBeaconSetup();	22 void BrowserBlacklistBeaconSetup();

21	23

	24 // Retrieves the set of blacklisted modules that are loaded in the process.

	25 bool RetrieveBlacklistedModules(std::vector<base::string16>* module_names);
	csharp 2014/08/05 21:08:59 This names doesn't quite seem to match, maybe Retr This names doesn't quite seem to match, maybe RetrieveLoadedBlacklistedModules? (The current name just sounds like it will get a list of all the modules we blacklist) robertshield 2014/08/06 16:38:32 Renamed to GetLoadedBlacklistModules. Show quoted text On 2014/08/05 21:08:59, csharp wrote: > This names doesn't quite seem to match, maybe RetrieveLoadedBlacklistedModules? > (The current name just sounds like it will get a list of all the modules we > blacklist) Renamed to GetLoadedBlacklistModules.
	26

22 #endif // CHROME_BROWSER_CHROME_ELF_INIT_WIN_H_	27 #endif // CHROME_BROWSER_CHROME_ELF_INIT_WIN_H_

OLD	NEW