history: Use keyIdentifier instead of keyCode where possible.

chrome/browser/resources/history/history.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="../uber/uber_utils.js">
 <include src="history_focus_manager.js">
 
 ///////////////////////////////////////////////////////////////////////////////
 // Globals:
 /** @const */ var RESULTS_PER_PAGE = 150;
@@ skipping 465 matching lines @@
     controls.push(this.dropDown);
 
   return controls;
 };
 
 /**
  * @param {Event} e A keydown event to handle.
  * @private
  */
 Visit.prototype.handleKeydown_ = function(e) {
-  var keyCode = e.keyCode;
-  if (keyCode == 8 || keyCode == 46) {  // Delete or Backspace.
+  if (e.keyCode == 8 || e.keyCode == 46) {  // Delete or Backspace.
     if (!this.model_.isDeletingVisits())
       this.removeEntryFromHistory_(e);
     return;
   }
 
   var target = e.target;
-  if (target != document.activeElement || !(keyCode == 37 || keyCode == 39)) {
-    // Handling key code for inactive element or key wasn't left or right.
+  var key = e.keyIdentifier;
+  if (target != document.activeElement || !(key == 'Left' || key == 'Right'))
     return;
-  }
 
   var controls = this.getFocusableControls_();
   for (var i = 0; i < controls.length; ++i) {
     if (controls[i].contains(target)) {
-      /** @const */ var isLeft = e.keyCode == 37;
-      var toFocus = isLeft ? controls[i - 1] : controls[i + 1];
+      var toFocus = key == 'Left' ? controls[i - 1] : controls[i + 1];
       if (toFocus) {
         this.focusControl(toFocus);
         e.preventDefault();
       }
       break;
     }
   }
 };
 
 /**
@@ skipping 1163 matching lines @@
 
   activeVisit.setIsLead(false);
 };
 
 /**
  * @param {Event} e A keydown event to handle.
  * @private
  */
 HistoryView.prototype.handleKeydown_ = function(e) {
   // Only handle up or down arrows on the focused element.
-  var keyCode = e.keyCode, target = e.target;
-  if (target != document.activeElement || !(keyCode == 38 || keyCode == 40))
+  var key = e.keyIdentifier, target = e.target;
+  if (target != document.activeElement || !(key == 'Up' || key == 'Down'))
     return;
 
   var entry = findAncestorByClass(e.target, 'entry');
   var visit = entry && entry.visit;
-  this.swapFocusedVisit_(keyCode == 38 ? this.getVisitBefore_(visit) :
-                                         this.getVisitAfter_(visit));
+  this.swapFocusedVisit_(key == 'Up' ? this.getVisitBefore_(visit) :
+                                       this.getVisitAfter_(visit));
 };
 
 /**
  * @param {Event} e A mousedown event to handle.
  * @private
  */
 HistoryView.prototype.handleMousedown_ = function(e) {
   var target = e.target;
   var entry = findAncestorByClass(target, 'entry');
   if (!entry || !entry.contains(target))
@@ skipping 625 matching lines @@
     historyView.reload();
 }
 
 // Add handlers to HTML elements.
 document.addEventListener('DOMContentLoaded', load);
 
 // This event lets us enable and disable menu items before the menu is shown.
 document.addEventListener('canExecute', function(e) {
   e.canExecute = true;
 });