Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 444503005: Remove non-trivial subtyping between bitset and non-bitset types. (Closed)

Created:
6 years, 4 months ago by neis
Modified:
6 years, 4 months ago
Reviewers:
rossberg
Project:
v8
Visibility:
Public.

Description

Remove non-trivial subtyping between bitset and non-bitset types. R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22903

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -45 lines) Patch
M src/types.cc View 1 5 chunks +2 lines, -45 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
neis
6 years, 4 months ago (2014-08-05 15:03:49 UTC) #1
rossberg
https://codereview.chromium.org/444503005/diff/1/src/types.cc File src/types.cc (right): https://codereview.chromium.org/444503005/diff/1/src/types.cc#newcode25 src/types.cc:25: for (int i = 0; i < unioned->Length(); ++i) ...
6 years, 4 months ago (2014-08-05 15:07:54 UTC) #2
neis
https://codereview.chromium.org/444503005/diff/1/src/types.cc File src/types.cc (right): https://codereview.chromium.org/444503005/diff/1/src/types.cc#newcode25 src/types.cc:25: for (int i = 0; i < unioned->Length(); ++i) ...
6 years, 4 months ago (2014-08-05 17:01:10 UTC) #3
rossberg
lgtm
6 years, 4 months ago (2014-08-06 07:07:46 UTC) #4
neis
6 years, 4 months ago (2014-08-06 08:28:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r22903 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698