Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issue 444503003: Cleanup V8_TURBOFAN_TARGET definition. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer
Modified:
6 years, 4 months ago
Reviewers:
titzer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Cleanup V8_TURBOFAN_TARGET definition. Move to globals.h so we do no longer skip any number of tests. Introduce V8_TURBOFAN_BACKEND, which is 1 if we actually have a backend and want to compile it, but don't run the tests. R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22863

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -25 lines) Patch
M src/compiler/arm64/instruction-selector-arm64.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/compiler/code-generator.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M src/compiler/pipeline.h View 2 chunks +1 line, -10 lines 0 comments Download
M src/globals.h View 1 chunk +13 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
6 years, 4 months ago (2014-08-05 11:51:03 UTC) #1
titzer
lgtm
6 years, 4 months ago (2014-08-05 11:53:06 UTC) #2
Benedikt Meurer
6 years, 4 months ago (2014-08-05 11:53:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 22863 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698