Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1512)

Unified Diff: content/renderer/render_frame_proxy.cc

Issue 444503002: Start using RenderFrameProxyHost objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Create view IFF frame is main frame Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_proxy.h ('k') | content/renderer/render_thread_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_proxy.cc
diff --git a/content/renderer/render_frame_proxy.cc b/content/renderer/render_frame_proxy.cc
index e8da0014e1ce84e6db58bb92f53f0a2785f4fba3..14670716dfee75ba73d6c658a4e90db05bc3f45d 100644
--- a/content/renderer/render_frame_proxy.cc
+++ b/content/renderer/render_frame_proxy.cc
@@ -38,8 +38,7 @@ RenderFrameProxy* RenderFrameProxy::CreateProxyToReplaceFrame(
scoped_ptr<RenderFrameProxy> proxy(
new RenderFrameProxy(routing_id, frame_to_replace->GetRoutingID()));
-#if 0
- // TODO(nick): Enable this code when we're ready to create WebRemoteFrames.
+
blink::WebRemoteFrame* web_frame = NULL;
if (frame_to_replace->GetWebFrame()->parent() &&
frame_to_replace->GetWebFrame()->parent()->isWebRemoteFrame()) {
@@ -49,9 +48,7 @@ RenderFrameProxy* RenderFrameProxy::CreateProxyToReplaceFrame(
} else {
web_frame = blink::WebRemoteFrame::create(proxy.get());
}
-#else
- blink::WebFrame* web_frame = frame_to_replace->GetWebFrame();
-#endif
+
proxy->Init(web_frame, frame_to_replace->render_view());
return proxy.release();
}
@@ -70,15 +67,12 @@ RenderFrameProxy* RenderFrameProxy::CreateFrameProxy(
web_frame = blink::WebRemoteFrame::create(proxy.get());
render_view->webview()->setMainFrame(web_frame);
} else {
- // Create a frame under an existing parent. The parent is always expected to
- // be a RenderFrameProxy, because navigations initiated by local frames
+ // Create a frame under an existing parent. The parent is always expected
+ // to be a RenderFrameProxy, because navigations initiated by local frames
// should not wind up here.
RenderFrameProxy* parent =
RenderFrameProxy::FromRoutingID(parent_routing_id);
- CHECK(parent);
- CHECK(parent->web_frame()->isWebRemoteFrame());
- web_frame = parent->web_frame()->toWebRemoteFrame()->createRemoteChild(
- "", proxy.get());
+ web_frame = parent->web_frame()->createRemoteChild("", proxy.get());
render_view = parent->render_view();
}
@@ -132,7 +126,7 @@ RenderFrameProxy::~RenderFrameProxy() {
web_frame()->close();
}
-void RenderFrameProxy::Init(blink::WebFrame* web_frame,
+void RenderFrameProxy::Init(blink::WebRemoteFrame* web_frame,
RenderViewImpl* render_view) {
CHECK(web_frame);
CHECK(render_view);
« no previous file with comments | « content/renderer/render_frame_proxy.h ('k') | content/renderer/render_thread_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698