content/browser/web_contents/opened_by_dom_browsertest.cc - Issue 444503002: Start using RenderFrameProxyHost objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/opened_by_dom_browsertest.cc

Issue 444503002: Start using RenderFrameProxyHost objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Create view IFF frame is main frame Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/opened_by_dom_browsertest.cc

diff --git a/content/browser/web_contents/opened_by_dom_browsertest.cc b/content/browser/web_contents/opened_by_dom_browsertest.cc

index 1c2d94099ce1d94e0d8c3fa126a974360f523b6a..26a802c6512f649d96fe07a4433acb20140380e7 100644

--- a/content/browser/web_contents/opened_by_dom_browsertest.cc

+++ b/content/browser/web_contents/opened_by_dom_browsertest.cc

@@ -114,7 +114,8 @@ IN_PROC_BROWSER_TEST_F(OpenedByDOMTest, Popup) {

// Tests that window.close() works in a popup window that has navigated a few

// times and swapped processes.

-IN_PROC_BROWSER_TEST_F(OpenedByDOMTest, CrossProcessPopup) {

+// Crashes on all platforms. http://crbug.com/399709

+IN_PROC_BROWSER_TEST_F(OpenedByDOMTest, DISABLED_CrossProcessPopup) {

host_resolver()->AddRule("*", "127.0.0.1");

ASSERT_TRUE(test_server()->Start());