Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1496)

Issue 444493005: MacViews: Remove aura dependency from omnibox_view_views_browsertest (Closed)

Created:
6 years, 4 months ago by tapted
Modified:
6 years, 4 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina, James Su, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

MacViews: Remove aura dependency from omnibox_view_views_browsertest This is done by using the cross-platform EventGenerator to craft and dispatch test events. BUG=399191 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287707

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -24 lines) Patch
M chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc View 2 chunks +9 lines, -24 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
tapted
Hi Peter, please take a look. (this is towards getting interactive_ui_tests compiling on mac with ...
6 years, 4 months ago (2014-08-05 13:52:13 UTC) #1
Peter Kasting
LGTM
6 years, 4 months ago (2014-08-05 17:47:10 UTC) #2
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 4 months ago (2014-08-05 23:18:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/444493005/1
6 years, 4 months ago (2014-08-05 23:19:27 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 06:27:54 UTC) #5
Message was sent while issue was closed.
Change committed as 287707

Powered by Google App Engine
This is Rietveld 408576698