Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 444463007: Initialize the global message center instance to NULL (Closed)

Created:
6 years, 4 months ago by Mikus
Modified:
6 years, 4 months ago
Reviewers:
stevenjb
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Initialize the global message center instance to NULL BUG=Uninitialized global message center instance leads to trouble when modifying gyps. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287763

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/message_center/message_center.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Mikus
6 years, 4 months ago (2014-08-05 07:39:38 UTC) #1
stevenjb
lgtm
6 years, 4 months ago (2014-08-05 15:52:54 UTC) #2
Mikus
The CQ bit was checked by mboc@opera.com
6 years, 4 months ago (2014-08-06 07:19:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mboc@opera.com/444463007/1
6 years, 4 months ago (2014-08-06 07:21:00 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-06 10:49:25 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 12:00:01 UTC) #6
Message was sent while issue was closed.
Change committed as 287763

Powered by Google App Engine
This is Rietveld 408576698