drive: Trigger "fast fetch" if remote update came during full loading.

drive: Trigger "fast fetch" if remote update came during full loading.

* AboutResource is updated as soon as the remote update is notified.

* The condition to trigger the fast-fetch mode is changed.
Previously we've skipped it if the directory changestamp is
close to the server changestamp, expecting the normal fetch
will finish very soon in that case. To correctly grasp the
expectation, however, we need to compare by using the changestamp
of the whole metadata in the DB, not the directory's.

BUG=329732
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287761

[hashimoto, 2014-08-06 05:55:43]

https://codereview.chromium.org/444463005/diff/70001/chrome/browser/chromeos/...
File chrome/browser/chromeos/drive/change_list_loader.cc (right):

https://codereview.chromium.org/444463005/diff/70001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/change_list_loader.cc:346: if (loaded_) {
nit: Can't we replace this "if" with DCHECK?

https://codereview.chromium.org/444463005/diff/70001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/change_list_loader.cc:361:
about_resource_loader_->UpdateAboutResource(
GetAboutResource() requests the resource if not available.
Why should we call UpdateAboutResource() here?

[kinaba, 2014-08-06 06:16:54]

https://codereview.chromium.org/444463005/diff/70001/chrome/browser/chromeos/...
File chrome/browser/chromeos/drive/change_list_loader.cc (right):

https://codereview.chromium.org/444463005/diff/70001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/change_list_loader.cc:346: if (loaded_) {
On 2014/08/06 05:55:43, hashimoto wrote:
> nit: Can't we replace this "if" with DCHECK?

Done.

https://codereview.chromium.org/444463005/diff/70001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/change_list_loader.cc:361:
about_resource_loader_->UpdateAboutResource(
On 2014/08/06 05:55:43, hashimoto wrote:
> GetAboutResource() requests the resource if not available.
> Why should we call UpdateAboutResource() here?

Good point. Done.

[hashimoto, 2014-08-06 06:37:06]

lgtm

[kinaba, 2014-08-06 06:38:20]

The CQ bit was checked by kinaba@chromium.org

[commit-bot: I haz the power, 2014-08-06 06:40:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kinaba@chromium.org/444463005/90001

[kinaba, 2014-08-06 07:43:20]

The CQ bit was unchecked by kinaba@chromium.org

[kinaba, 2014-08-06 07:48:21]

On 2014/08/06 07:43:20, kinaba wrote:
> The CQ bit was unchecked by mailto:kinaba@chromium.org

Fixed a test. @hashimoto: please take a quick look

[hashimoto, 2014-08-06 07:50:52]

lgtm

[kinaba, 2014-08-06 07:51:14]

On 2014/08/06 07:50:52, hashimoto wrote:
> lgtm

thanks!

[kinaba, 2014-08-06 07:51:17]

The CQ bit was checked by kinaba@chromium.org

[commit-bot: I haz the power, 2014-08-06 07:52:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kinaba@chromium.org/444463005/110001

[commit-bot: I haz the power, 2014-08-06 10:38:21]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-06 11:52:03]

Change committed as 287761