Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Issue 444453006: Setup dependency to use Blink IDL parser (w/ support libs) and latest IDLs. (Closed)

Created:
6 years, 4 months ago by terry
Modified:
6 years, 3 months ago
Reviewers:
vsm, Emily Fortuna
Visibility:
Public.

Description

Setup dependency to use Blink IDL parser (w/ support libs) and latest IDLs. BUG=

Patch Set 1 #

Patch Set 2 : Updated to latest roll #

Patch Set 3 : Fixed merging problem #

Patch Set 4 : Little more cleanup, bring in just minimum needed. #

Patch Set 5 : "Point to rev in trunk and not branch." #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M all.deps/DEPS View 1 2 3 4 4 chunks +28 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
terry
Checking in DEPS before rest of code to use Blink's IDL parser, Python libs for ...
6 years, 4 months ago (2014-08-05 16:51:55 UTC) #1
Emily Fortuna
lgtm. thank you, Terry.
6 years, 4 months ago (2014-08-05 17:01:39 UTC) #2
vsm
https://chromiumcodereview.appspot.com/444453006/diff/70001/all.deps/DEPS File all.deps/DEPS (right): https://chromiumcodereview.appspot.com/444453006/diff/70001/all.deps/DEPS#newcode110 all.deps/DEPS:110: Var("dartium_base") + Var("blink_modules") + Var("dartium_webkit_revision"), How much bigger / ...
6 years, 4 months ago (2014-08-06 11:16:56 UTC) #3
terry
https://chromiumcodereview.appspot.com/444453006/diff/70001/all.deps/DEPS File all.deps/DEPS (right): https://chromiumcodereview.appspot.com/444453006/diff/70001/all.deps/DEPS#newcode110 all.deps/DEPS:110: Var("dartium_base") + Var("blink_modules") + Var("dartium_webkit_revision"), I realize there is ...
6 years, 4 months ago (2014-08-06 15:16:27 UTC) #4
vsm
6 years, 4 months ago (2014-08-14 15:17:51 UTC) #5
On 2014/08/06 15:16:27, terry wrote:
> https://chromiumcodereview.appspot.com/444453006/diff/70001/all.deps/DEPS
> File all.deps/DEPS (right):
> 
>
https://chromiumcodereview.appspot.com/444453006/diff/70001/all.deps/DEPS#new...
> all.deps/DEPS:110: Var("dartium_base") + Var("blink_modules") +
> Var("dartium_webkit_revision"),
> I realize there is a lot of unused stuff but it seems overall relatively small
-
> adds a little more than 10 sec to gclient (first time for entire download). 
> It's nice that there is a very simple way to roll forward.
> 
> Maybe we could get the Blink folks to change there bindings directory for
script
> so we don't have to grab all the test stuff too.  I don't know of a way to get
> just one file from a directory (bindings/IDLExtendedAttributes.txt) then we'd
> only need bindings/scripts.
> 
> However, core is were most of the waste is with the .cpp/.h stuff that's
> probably a harder sell to re-arrange would be nice if core/idl/* had all the
> IDLs and modules/idl/* had all the IDLs.
> 
> 81M core (used ~1.8M of IDLs used plus css/*.in)
> 16M modules (~900K of IDLs used)
> 14M bindings (used scripts/ 1.1M and IDLExtendedAttributes.txt) Rest not
needed
> (6-7M of tests, v8/custom and dart/custom).
> 
> Currently in third_party there is 1.1G (w/o the Chrome stuff we'll add another
> .1G w/ third_party/chrome)
> 
> Adds about 12 sec to 'gclient sync' (first time)

Sorry for the slow reply on this.

Before, I would typically do this:

  cd third_party # In a regular dart enlistment
  mv WebCore WebCore.svn
  git svn clone -rHEAD https://dart.googlecode.com/svn/third_party/WebCore
  ../../tools/dom/scripts/idlsync.py
  git add *
  git commit -a -m "..."

This would update the IDL files under third_party/WebCore to exactly those in
the latest Dartium - and strip out the large chunk of files we don't need. 
Would this still work for you?  It seems lower impact and not really any more
work to maintain.  The above sequence still seems to do the right thing.







> 
> 
> 
> 
> On 2014/08/06 11:16:56, vsm wrote:
> > How much bigger / slower does this make a regular Dart checkout?  It's
pulling
> > in a lot of stuff (e.g,, C++) that we don't need.
> > 
> > An alternative is to do something like third_party/WebCore below, where we
> copy
> > only the files in Blink we need somewhere under the Dart repo and sync in
that
> > pre-filtered branch instead (updated via tools/dom/idlsync.py back in the
old
> > days).

Powered by Google App Engine
This is Rietveld 408576698