Issue 444453002: Revert "Revert of Telemetry: Last ditch effort to dump symbols on tab crashes if none are found (ht…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 444453002: Revert "Revert of Telemetry: Last ditch effort to dump symbols on tab crashes if none are found (ht… (Closed)

Created:
6 years, 4 months ago by oystein (OOO til 10th of July)

Modified:
6 years, 4 months ago

Reviewers:
dtu, tonyg

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert "Revert of Telemetry: Last ditch effort to dump symbols on tab crashes if none are found (https://codereview.chromium.org/318123002/)" This reverts https://codereview.chromium.org/320693002/ The original regression this caused (PageRunnerTests.testHandlingOfCrashedTab in telemetry_unittests) does not seem to be happening anymore (locally or on trybots), but please revert and let me know if it happens on the main waterfall. TBR=tonyg,dtu BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287612

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -18 lines)			Patch
	M	tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py	View		1 chunk	+34 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

oystein (OOO til 10th of July)

The CQ bit was checked by oysteine@chromium.org

6 years, 4 months ago (2014-08-05 18:25:48 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oysteine@chromium.org/444453002/1

6 years, 4 months ago (2014-08-05 18:27:50 UTC) #2

robliao

6 years, 4 months ago (2014-08-06 00:05:49 UTC) #4

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/446743002/ by robliao@chromium.org.

The reason for reverting is: Macbots are getting stuck here:
[       OK ] page_runner_unittest.PageRunnerTests.testDiscardFirstResult (10464
ms)
[ RUN      ] page_runner_unittest.PageRunnerTests.testHandlingOfCrashedTab
[ RUN      ] chrome://crash

http://build.chromium.org/p/chromium.mac/waterfall?builder=Mac10.6%20Tests%20(3)
http://build.chromium.org/p/chromium.mac/waterfall?builder=Mac10.7%20Tests%20(3).

Expand Messages | Collapse Messages