tests_lit/llvm2ice_tests/ebp_args.ll - Issue 444443002: Subzero: Align the stack at the point of function calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests_lit/llvm2ice_tests/ebp_args.ll

Issue 444443002: Subzero: Align the stack at the point of function calls. (Closed) Base URL: https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master

Patch Set: First round of comments. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests_lit/llvm2ice_tests/ebp_args.ll

diff --git a/tests_lit/llvm2ice_tests/ebp_args.ll b/tests_lit/llvm2ice_tests/ebp_args.ll

index e7acd5098862fe7d7078068fed0c27d519acb81e..6a33b2b8b1401919c1e7b481be52862f0043ce35 100644

--- a/tests_lit/llvm2ice_tests/ebp_args.ll

+++ b/tests_lit/llvm2ice_tests/ebp_args.ll

@@ -22,18 +22,23 @@ entry:

; lowering code changes.

; CHECK: memcpy_helper:

-; CHECK: push ebp

-; CHECK: mov ebp, esp

-; CHECK: sub esp, 20

-; CHECK: mov eax, dword ptr [ebp+12]

-; CHECK: mov dword ptr [ebp-4], eax

-; CHECK: sub esp, 128

-; CHECK: mov dword ptr [ebp-8], esp

-; CHECK: mov eax, dword ptr [ebp-8]

-; CHECK: mov dword ptr [ebp-12], eax

-; CHECK: movzx eax, byte ptr [ebp-4]

-; CHECK: mov dword ptr [ebp-16], eax

-; CHECK: push dword ptr [ebp-16]

-; CHECK: push dword ptr [ebp-12]

-; CHECK: push dword ptr [ebp+8]

-; CHECK: call memcpy_helper2

+; CHECK: push ebx

+; CHECK: push ebp

+; CHECK: mov ebp, esp

+; CHECK: sub esp, 20

+; CHECK: mov eax, dword ptr [ebp+16]

+; CHECK: mov dword ptr [ebp-4], eax

+; CHECK: sub esp, 128

+; CHECK: mov dword ptr [ebp-8], esp

+; CHECK: mov eax, dword ptr [ebp-8]

+; CHECK: mov dword ptr [ebp-12], eax

+; CHECK: movzx eax, byte ptr [ebp-4]

+; CHECK: mov dword ptr [ebp-16], eax

+; CHECK: sub esp, 16

+; CHECK: mov ecx, dword ptr [ebp+12]

+; CHECK: mov dword ptr [esp], ecx

+; CHECK: mov edx, dword ptr [ebp-12]

+; CHECK: mov dword ptr [esp+4], edx

+; CHECK: mov ebx, dword ptr [ebp-16]

+; CHECK: mov dword ptr [esp+8], ebx

+; CHECK: call memcpy_helper2

« src/IceTargetLoweringX8632.cpp ('K') | « tests_lit/llvm2ice_tests/alloc.ll ('k') | tests_lit/llvm2ice_tests/fp.pnacl.ll » ('j') | no next file with comments »