Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: src/IceInstX8632.h

Issue 444443002: Subzero: Align the stack at the point of function calls. (Closed) Base URL: https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master
Patch Set: Improve wording of a comment and reorder function in crosstest Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceInstX8632.h
diff --git a/src/IceInstX8632.h b/src/IceInstX8632.h
index 18f0dde9508ab199960718a729725c93b9b7b913..7a7e754b265c328ecd3b18ee999acd09a3caf4cf 100644
--- a/src/IceInstX8632.h
+++ b/src/IceInstX8632.h
@@ -137,6 +137,7 @@ public:
Add,
Addps,
Addss,
+ Adjuststack,
And,
Blendvps,
Br,
@@ -204,6 +205,7 @@ public:
Shufps,
Sqrtss,
Store,
+ StoreP,
StoreQ,
Sub,
Subps,
@@ -340,6 +342,26 @@ private:
InstX8632Label *Label; // Intra-block branch target
};
+// AdjustStack instruction - subtracts esp by the given amount and
+// updates the stack offset during code emission.
+class InstX8632AdjustStack : public InstX8632 {
+public:
+ static InstX8632AdjustStack *create(Cfg *Func, SizeT Amount) {
+ return new (Func->allocate<InstX8632AdjustStack>())
+ InstX8632AdjustStack(Func, Amount);
+ }
+ virtual void emit(const Cfg *Func) const;
+ virtual void dump(const Cfg *Func) const;
+ static bool classof(const Inst *Inst) { return isClassof(Inst, Adjuststack); }
+
+private:
+ InstX8632AdjustStack(Cfg *Func, SizeT Amount);
+ InstX8632AdjustStack(const InstX8632AdjustStack &) LLVM_DELETED_FUNCTION;
+ InstX8632AdjustStack &operator=(const InstX8632AdjustStack &)
+ LLVM_DELETED_FUNCTION;
+ SizeT Amount;
+};
+
// Call instruction. Arguments should have already been pushed.
class InstX8632Call : public InstX8632 {
public:
@@ -976,6 +998,23 @@ private:
virtual ~InstX8632Movp() {}
};
+class InstX8632StoreP : public InstX8632 {
+public:
+ static InstX8632StoreP *create(Cfg *Func, Operand *Value, OperandX8632 *Mem) {
+ return new (Func->allocate<InstX8632StoreP>())
+ InstX8632StoreP(Func, Value, Mem);
+ }
+ virtual void emit(const Cfg *Func) const;
+ virtual void dump(const Cfg *Func) const;
+ static bool classof(const Inst *Inst) { return isClassof(Inst, StoreP); }
+
+private:
+ InstX8632StoreP(Cfg *Func, Operand *Value, OperandX8632 *Mem);
+ InstX8632StoreP(const InstX8632StoreP &) LLVM_DELETED_FUNCTION;
+ InstX8632StoreP &operator=(const InstX8632StoreP &) LLVM_DELETED_FUNCTION;
+ virtual ~InstX8632StoreP() {}
+};
+
// This is essentially a "movq" instruction with an OperandX8632Mem
// operand instead of Variable as the destination. It's important
// for liveness that there is no Dest operand.

Powered by Google App Engine
This is Rietveld 408576698